Closed Bug 455742 Opened 11 years ago Closed 11 years ago

outparamdel nsIForm

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file)

Attached patch outparamdellingSplinter Review
From what I can see only ResolveName,GetElementCount,IndexOfControl control could be modified. The rest use nsresult to pass additional info.
I'm also not sure what the point of DoResolveName is. I left it in for now.
Attachment #339087 - Flags: review?(jst)
+  PRUint32 count = nsnull;

Should use a plain zero. (two places)
(In reply to comment #1)
> +  PRUint32 count = nsnull;
> 
> Should use a plain zero. (two places)

thanks, i'll fix those before commit
QA Contact: content
Attachment #339087 - Flags: superreview+
Attachment #339087 - Flags: review?(jst)
Attachment #339087 - Flags: review+
Comment on attachment 339087 [details] [diff] [review]
outparamdelling

Looks good!
http://hg.mozilla.org/mozilla-central/rev/51c533bbac70
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 472167
Component: Content → DOM
QA Contact: content → general
Assignee: nobody → tglek
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.