Closed
Bug 455762
Opened 16 years ago
Closed 6 years ago
Remove the extraneous |class| attribute in |<script class="testbody" type="text/javascript">| of test.template.txt and xhtml.template.txt
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(2 files)
And from all the 600- tests which have copied it ;-< IIRC, Robert said he agreed. *** While at it, replace these "text/javascript" by "application/javascript". Some script already have that.
Assignee | ||
Comment 1•16 years ago
|
||
Updated•16 years ago
|
Attachment #339155 -
Flags: review?(sayrer) → review+
Assignee | ||
Comment 2•16 years ago
|
||
Comment on attachment 339155 [details] [diff] [review] (Av1) <*.template.txt> [Checkin: Comment 2] http://hg.mozilla.org/mozilla-central/rev/8b1da13a315e
Attachment #339155 -
Attachment description: (Av1) <*.template.txt> → (Av1) <*.template.txt>
[Checkin: Comment 2]
Assignee | ||
Comment 3•16 years ago
|
||
This patch size is 2 MB... I used a "find and replace" utility, searching for whole lines. Does this need sr ? (Who from ?)
Attachment #339166 -
Flags: review?(sayrer)
Comment 4•16 years ago
|
||
Comment on attachment 339166 [details]
(Bv1) Apply (x)html fixes
This doesn't require SR, but it better land when the tree is perfectly green, and be tested ahead of time.
Attachment #339166 -
Flags: review?(sayrer) → review+
At least some of the Mochitests can also be run under IE, which is nice to compare results. This change of the script type attribute would make that harder.
Updated•16 years ago
|
Attachment #339155 -
Flags: review+ → review-
Comment 6•16 years ago
|
||
Comment on attachment 339166 [details]
(Bv1) Apply (x)html fixes
OK, let's not change the type. Sorry about that.
Attachment #339166 -
Flags: review+ → review-
Assignee | ||
Comment 7•16 years ago
|
||
(In reply to comment #5) > At least some of the Mochitests can also be run under IE, which is nice to > compare results. This change of the script type attribute would make that > harder. Could you tell me a little more about this: How can our (automated) tests be run in MsIE ? What brakes them in my patch ? Should we rather "fix" some other tests in the opposite way ? ...
Comment 8•16 years ago
|
||
Apparently, MsIE doesn't support the type=application/javascript. You can run the tests in IE, while the server is up and running, so while running (or waiting to run) tests in Firefox.
Updated•16 years ago
|
Component: Testing → Mochitest
Product: Core → Testing
QA Contact: testing → mochitest
Version: Trunk → unspecified
Comment 9•6 years ago
|
||
Mass closing mochitest bugs that haven't had activity in the past 5 years. Please re-open or file a new bug with modern context if this is still relevant.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•