Closed
Bug 455803
Opened 16 years ago
Closed 16 years ago
Rename SeaMonkey.url.(mailto|news) registry keys
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcsmurf, Assigned: mcsmurf)
References
Details
Attachments
(1 file)
|
4.50 KB,
patch
|
neil
:
review+
neil
:
superreview+
kairo
:
approval-seamonkey2.0a1+
|
Details | Diff | Splinter Review |
The HKEY_LOCAL_MACHINE\SOFTWARE\Classes\SeaMonkey.Url.news and HKEY_LOCAL_MACHINE\SOFTWARE\Classes\SeaMonkey.Url.mailto are not really consistent with the HKEY_LOCAL_MACHINE\SOFTWARE\Classes\SeaMonkeyURL reg key, the names of those two should be changed. With regards to Bug 418150, the names should probably be SeaMonkeyNEWS and SeaMonkeyCOMPOSE.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #339151 -
Flags: superreview?(neil)
Attachment #339151 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Attachment #339151 -
Flags: superreview?(neil)
Attachment #339151 -
Flags: superreview+
Attachment #339151 -
Flags: review?(neil)
Attachment #339151 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #339151 -
Flags: approval-seamonkey2.0a1?
|
|
Assignee | |
Comment 2•16 years ago
|
||
No big risk, registry keys get renamed. Only "risk" is that the old keys do not get removed (when someone already uses SeaMonkey trunk), but that is no real problem.
|
|
Assignee | |
Updated•16 years ago
|
Assignee: bugzilla → installer
Component: General → Installer
QA Contact: general → xpi-packages
|
|
Assignee | |
Updated•16 years ago
|
Assignee: installer → bugzilla
|
||
Comment 3•16 years ago
|
||
Comment on attachment 339151 [details] [diff] [review]
Patch
Yes, let's take that for Alpha1 still, though looking more closely at it, I'm not sure if "COMPOSE" is ideal for mailto, as it could easily be mistaken for something related to the composer component.
Attachment #339151 -
Flags: approval-seamonkey2.0a1? → approval-seamonkey2.0a1+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Yes, the plan is to use that one for the -compose flag, so have to name it like that.
|
|
Assignee | |
Comment 5•16 years ago
|
||
Pushed to c-c, changeset 89ec2aa13b4e.
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•