TM: Unify and cleanup equal and cmp

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

unspecified
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 339158 [details] [diff] [review]
Unify cmp and equal and eliminate a lot of redundant code. Not working, just a preview.
(Assignee)

Comment 1

10 years ago
cmp and equal are totally gross. This patch tries to unify and streamline the code and add support for more cases. Needs to be tested. I am putting this up for feedback.
(Assignee)

Updated

10 years ago
Assignee: general → gal
(Assignee)

Comment 2

10 years ago
This patch also fixes a bug in cmp/equals. We check for JSVAL_IS_NULL(l) and then assume at runtime that its again a comparison against null, but since null is just one value out of the Object domain we actually have to also check that l_ins->isconst(). Thats fixed in this patch.
(Assignee)

Comment 3

10 years ago
Created attachment 339276 [details] [diff] [review]
Working patch.
Attachment #339276 - Flags: review?(danderson)
(Assignee)

Updated

10 years ago
Attachment #339158 - Attachment is obsolete: true
Attachment #339276 - Flags: review?(danderson) → review+
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.