Closed
Bug 455811
Opened 16 years ago
Closed 16 years ago
TM: Unify and cleanup equal and cmp
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: gal)
Details
Attachments
(1 file, 1 obsolete file)
|
14.65 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•16 years ago
|
||
cmp and equal are totally gross. This patch tries to unify and streamline the code and add support for more cases. Needs to be tested. I am putting this up for feedback.
|
|
Assignee | |
Updated•16 years ago
|
Assignee: general → gal
|
|
Assignee | |
Comment 2•16 years ago
|
||
This patch also fixes a bug in cmp/equals. We check for JSVAL_IS_NULL(l) and then assume at runtime that its again a comparison against null, but since null is just one value out of the Object domain we actually have to also check that l_ins->isconst(). Thats fixed in this patch.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #339276 -
Flags: review?(danderson)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #339158 -
Attachment is obsolete: true
|
||
Updated•16 years ago
|
Attachment #339276 -
Flags: review?(danderson) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/c82703d1d8c1
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•