Created attachment 339158 [details] [diff] [review] Unify cmp and equal and eliminate a lot of redundant code. Not working, just a preview.
cmp and equal are totally gross. This patch tries to unify and streamline the code and add support for more cases. Needs to be tested. I am putting this up for feedback.
This patch also fixes a bug in cmp/equals. We check for JSVAL_IS_NULL(l) and then assume at runtime that its again a comparison against null, but since null is just one value out of the Object domain we actually have to also check that l_ins->isconst(). Thats fixed in this patch.
Created attachment 339276 [details] [diff] [review] Working patch.
Attachment #339276 - Flags: review?(danderson)
Attachment #339158 - Attachment is obsolete: true
10 years ago
Attachment #339276 - Flags: review?(danderson) → review+
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.