Closed Bug 455840 Opened 11 years ago Closed 9 years ago

change test_nsIAccessible_focus.html mochitest to use eventQueue

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0

People

(Reporter: MarcoZ, Assigned: surkov)

References

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

In test_nsIAccessible_focus.html, when run with all tests, the test for focused state on the "aria-link" element fails. However right prior to that, the test for the corresponding dom node having focus passes.

Determine why getFinalState returns the wrong info in this case.

I already tried prolonging the timeout in this window.setTimeout function block, but even at 250, which is a quarter of a second, the result is no different, so the state is apparently not set at all.

The test is currently marked as known fail and wrapped in an if statement so the other tests for this state still have a chance to succeed.
Attached patch patch (obsolete) — Splinter Review
I can't recreate this bug.
Assignee: nobody → bolterbugz
Attachment #403277 - Flags: review?(marco.zehe)
Comment on attachment 403277 [details] [diff] [review]
patch

After discussing on IRC, we think it makes sense to tie this file into our new event handling rather than patching it up the other way. Cancelling review request.
Attachment #403277 - Flags: review?(marco.zehe)
Assignee: bolterbugz → marco.zehe
Marco, do we want to do anything here?
We should see if we have an equivalent test like the one indicated in the patch. If that works, close as WFM.
Attached patch patchSplinter Review
change mochitest to use eventQueue
Assignee: marco.zehe → surkov.alexander
Attachment #403277 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #518630 - Flags: review?(marco.zehe)
Summary: Determine why focused state is not set on aria-link event hough the dom node has focus. → change test_nsIAccessible_focus.html mochitest to use eventQueue
Comment on attachment 518630 [details] [diff] [review]
patch

Yes, that's looking good, thanks! r=me
Attachment #518630 - Flags: review?(marco.zehe) → review+
landed 2.0 - http://hg.mozilla.org/mozilla-central/rev/b78e947a68e5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
You need to log in before you can comment on or make changes to this bug.