Closed
Bug 455863
Opened 16 years ago
Closed 16 years ago
select event in unifinder scrolls multiday-view to time in its timezone, not view timezone
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: gekacheka, Assigned: gekacheka)
Details
Attachments
(1 file, 1 obsolete file)
3.82 KB,
patch
|
berend.cornelius09
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; is-IS; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.18pre) Gecko/20080917 Sunbird/0.9 When viewing week view or day view, selecting an event which has a timezone different from the display timezone scrolls to that events' local time, not the time in the current display timezone. Reproducible: Always Steps to Reproduce: 1. Open new event dialog 2. Ensure timezone is visible (options/timezone checkmark is on) 3. Set timezone to something different than the current timezone. For example, if current timezone is America/New York, set it to Europe/Paris. 4. Set time to noon. 5. Set title to "noon Paris" 6. Save and Close 7. Go to week view or day view. 8. Make sure the unifinder event list is visible. 9. click event "noon Paris" Actual Results: Day or week view scrolls to noon (display=new-york time, not paris time) Event "noon Paris" is not visible in day or week view because scrolled off screen. Expected Results: Day or week view scrolls to 6am (display=new-york time, noon paris time) Event "noon Paris" is visible in day or week view.
(patch -l -p 1 -i file.patch) Here's a draft patch. It works for the case in comment 0, but doesn't work for an event that crosses midnite.
(patch -l -p 1 -i file.patch) This patch works for both items in non-display timezone and items that cross midnite in the display timezone. Trims occurrence times within view (can't show occurrence end past end of week), converts times to display timezone (show where displayed), trims to end of start day for items that cross midnite (so will usually scroll to show start).
Assignee: nobody → gekacheka
Attachment #340833 -
Flags: review?(Berend.Cornelius)
Updated•16 years ago
|
Status: NEW → ASSIGNED
Updated•16 years ago
|
Attachment #339240 -
Attachment is obsolete: true
Comment 3•16 years ago
|
||
Comment on attachment 340833 [details] [diff] [review] v2 patch: scroll multiday view to item in display timezone (or start of multday item) patch looks and works well. r=berend
Attachment #340833 -
Flags: review?(Berend.Cornelius) → review+
Comment 4•16 years ago
|
||
patch pushed to comm-central: http://hg.mozilla.org/comm-central/rev/eef3905b0a36 ->fixed. Thank you for your contribution;
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Comment 5•16 years ago
|
||
Checked in lightning and sunbird build 20081221 -> VERIFIED.
Status: RESOLVED → VERIFIED
Comment 6•13 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•