455947 - subscribe dialog gives broken expression

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Right-click to subscribe on an imap folder, or newsgroup. The menu to select account is drawn in tiny height (no selection), and before you select an account in the list it all looks quite broken.

Comment 1

[Mark Banner (:standard8)]

We're not using the blocking-thunderbird3.0b1? flags now, we're using a combination of 3 and the target milestone.

Comment 2

[Joshua Cranmer [:jcranmer]]

I know why this is broken; it will be fixed when I finish stripping RDF from the subscribe dialog (done locally).

Comment 3

[Wayne Mery (:wsmwk)]

but selecting an account from drop down works right?

(In reply to comment #2)
> I know why this is broken; it will be fixed when I finish stripping RDF from
> the subscribe dialog (done locally).

bug#?
is the fixer bug 457333?

Comment 4

[Joshua Cranmer [:jcranmer]]

(In reply to comment #3)
> but selecting an account from drop down works right?

Right, it's just the auto-load functionality that's broken.

> (In reply to comment #2)
> > I know why this is broken; it will be fixed when I finish stripping RDF from
> > the subscribe dialog (done locally).
> bug#?
> is the fixer bug 457333?

Yes, buried somewhere in the diff. It's a simple one line fix, which I'll post on this bug when I find it again so that it gets in more quickly.

Comment 7

[David :Bienvenu]

Can you post the one line fix? We'd like to start driving down the beta2 blocker bugs and this looks like an easy one.

Comment 8

[David :Bienvenu]

Attachment: carve out jcranmer's fix from his big subscribe patch

asking jcranmer for review - it's basically his patch, but I tweaked it a little bit.

Comment 9

[David :Bienvenu]

fix checked in

Comment 10

[Joey Minta]

Attachment: mozmill test

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 348334 [details] [diff] [review]
mozmill test

This test doesn't finish and has the following error on the console:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'Error: javascript assert was not succesful' when calling method: [nsITimerCallback::notify]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "<unknown>"  data: no]
************************************************************

Comment 12

[Wayne Mery (:wsmwk)]

This FIXED bug is flagged with in‑testsuite?   It would be great if assignee or someone else can clear the flag if a test is not appropriate.  And if appropriate, create a test and plus the flag to finish off the bug.