455960 - define drop behaviour on sorted TreeViews

Status: RESOLVED DUPLICATE of bug 630961

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

spin off from bug 418671

> > >    canDrop: function PTV_canDrop(aRow, aOrientation) {
> > >      if (!this._result)
> > >        throw Cr.NS_ERROR_UNEXPECTED;
> > > 
> > > -    var node = aRow != -1 ? this.nodeForTreeIndex(aRow) : this._result.root;
> > > +    // drop position into a sorted treeview would be wrong
> > > +    if (this.isSorted())
> > > +      return false;
> > > 
> > > Didn't we use to drop at the end if the view is sorted?
> > 
> > i'm not sure it makes sense, maybe in a followup we should try dropping
> > "after_node", the main problem is that the dropFeedback will show they are
> > dropping at a certain position, but the drop will be at the end. I still think
> > we should try to explain users the difference between a sorted view and an
> > unsorted one when they are doing D&D.
> >
> 
> I can do that in iTunes, but it doesn't show the drag feeedback if the view is
> sorted. Can we do that?

the Drag feedback is set and invalidated in nsTreeBody, we could try hacking it
in some way, but if the drag is allowed it will be showed... drop is
disabled for now on sorted views, we should investigate possible
solutions or eventually re-enable old behaviour.

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 2

[Mark Banner (:standard8)]

Going to dupe forward to bug 630961 as that description is slightly clearer.