456096 - drag and drop folder fails - error nsITransferable.getAnyTransferData, messengerdnd.js :: DropOnFolderTree

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

drag and drop folder fails between accounts and between folders for all accounts I tested, local and imap. It offers to drop - error nsITransferable.getAnyTransferData, messengerdnd.js :: DropOnFolderTree. 

I don't have a solid regression range b/c august's drag problems.
08-23 works
08-28 fails
09-08 fails
09-13 fails 
09-18 fails

error console contains ...

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransferable.getAnyTransferData]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger/content/messengerdnd.js :: DropOnFolderTree :: line 266"  data: no]
Source File: chrome://messenger/content/messengerdnd.js
Line: 266

Comment 1

[Wayne Mery (:wsmwk)]

Serge, do you see this dnd problem in Seamonkey?
related to Bug 452832 or bug 453220?

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> I don't have a solid regression range b/c august's drag problems.
> 08-23 works
> 08-28 fails

Narrowing this down would help.

(In reply to comment #1)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080919031028 Shredder/3.0b1pre] (nightly) (W2Ksp4)

I reproduce very easily with TB.

> Serge, do you see this dnd problem in Seamonkey?

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080919073847 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

I can not reproduce with SM.

> related to Bug 452832 or bug 453220?

(Not obvious, from a Bugzilla point of view.)

Comment 3

[Wayne Mery (:wsmwk)]

This prevents testing and verification of other recent core drag and drop issues. Indeed if there's an overlap regressions we might not find the range via testing. But someone's welcome to try.

I was going to remove the b1 blocking request but reconsidered.

Comment 4

[Magnus Melin [:mkmelin]]

Regression window 2008-08-27->2008-08-28 linux builds
http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-08-27+03%3A03%3A38&enddate=2008-08-28+03%3A19%3A49
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-08-27+03%3A03%3A38&enddate=2008-08-28+03%3A19%3A49

... so very likely fallout from bug 356295.

Comment 5

[David :Bienvenu]

taking to investigate

Comment 6

[David :Bienvenu]

Attachment: proposed fix

GetSelectedFolders is different between SM and TB, perhaps as a result of de-rdf-ication (shocking, I know).  We need to be passing in the URI, not the folder, and since this is shared code, it seemed easier just to build up the array here. I'm open to other suggestions, however.

Comment 7

[[e-mail]]

Comment on attachment 340482 [details] [diff] [review]
proposed fix 

A de-RDF regression? How surprising!

Perhaps we can do something along the lines of
GetSelectedMsgFolders().map(function (f) { return f.URI; });

Comment 8

[David :Bienvenu]

changeset:   446:9286d1809f7b

I checked in my patch, but we could do what you suggested, actually. I'll test and attach a patch for that...

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080927031346 Shredder/3.0b1pre] (nightly) (W2Ksp4)

V.Fixed

Comment 10

[Axel Grude [:realRaven]]

Some of my users have crashes in TB2 when getAnyTransferData is called after dropping Emails to a popup menu in my QuickFolders extension. One thing all of these users have in common is that they use relatively recent Linux versions, the last one used Jounty. A try catch block does not resolve the issue.

Is there a general problem with getAnyTransferData under Linux? I will ask the user to install a test version of Shredder alpha3 to see whether it resolves the problem.