Closed Bug 456099 Opened 11 years ago Closed 11 years ago

outparamdel nsIPrivateDOMEvent

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(2 files)

Attached patch outparamdellingSplinter Review
No description provided.
Attachment #339510 - Flags: review?(jst)
QA Contact: content
Comment on attachment 339510 [details] [diff] [review]
outparamdelling

The nsXMLHttpRequest changes here might have bit-rotted due to a bunch of changes going into that code lately, so watch out for that once you go to land this.

r+sr=jst
Attachment #339510 - Flags: superreview+
Attachment #339510 - Flags: review?(jst)
Attachment #339510 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/650e6b065018
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Seeing as there hasn't been any discussions about this bug for 5 months and it's not really something that's testable on testsuite or litmus, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Status: RESOLVED → VERIFIED
Component: Content → DOM
QA Contact: content → general
The "nsSmartCardEvent.cpp" chunk of this bug's patch was a bit silly:
>diff --git a/security/manager/ssl/src/nsSmartCardEvent.cpp b/security/manager/ssl/src/nsSmartCardEvent.cpp
>-NS_IMETHODIMP nsSmartCardEvent::IsDispatchStopped(PRBool *aIsDispatchPrevented)
>+NS_IMETHODIMP_(PRBool ) nsSmartCardEvent::IsDispatchStopped()
> {
>+  PRBool  isDispatchPrevented = nsnull;
>+  PRBool * aIsDispatchPrevented = &isDispatchPrevented;
>   NS_ASSERTION(mPrivate, "SmartCardEvent called without Init");
>-  return mPrivate->IsDispatchStopped(aIsDispatchPrevented);
>+  return mPrivate->IsDispatchStopped();
> }
> 
>-NS_IMETHODIMP nsSmartCardEvent::GetInternalNSEvent(nsEvent** aNSEvent)
>+NS_IMETHODIMP_(nsEvent*) nsSmartCardEvent::GetInternalNSEvent()
> {
>+  nsEvent* nSEvent = nsnull;
>+  nsEvent** aNSEvent = &nSEvent;
>   NS_ASSERTION(mPrivate, "SmartCardEvent called without Init");
>-  return mPrivate->GetInternalNSEvent(aNSEvent);
>+  return mPrivate->GetInternalNSEvent();
> }
> 
>-NS_IMETHODIMP nsSmartCardEvent::HasOriginalTarget(PRBool *aResult)
>+NS_IMETHODIMP_(PRBool ) nsSmartCardEvent::HasOriginalTarget()
> {
>+  PRBool  result = nsnull;
>+  PRBool * aResult = &result;
>   NS_ASSERTION(mPrivate, "SmartCardEvent called without Init");
>-  return mPrivate->HasOriginalTarget(aResult);
>+  return mPrivate->HasOriginalTarget();
> }

We created two unused variables in three different functions.

The last function (HasOriginalTarget) has since been removed entirely, but the other two still remain and still trigger build warnings for their unused variables.

Attached followup-patch fixes this.
Attachment #423973 - Flags: review?(tglek)
Comment on attachment 423973 [details] [diff] [review]
followup: remove unused variables introduced by earlier patch

I'd requested review from Taras, the author of this bug's original patch, but it looks like he's gone for another 2.5 weeks.

So, I'm redirecting review-request on (trivial) followup to jst, the reviewer of this bug's original patch.
Attachment #423973 - Flags: review?(tglek) → review?(jst)
Attachment #423973 - Flags: review?(jst) → review+
Depends on: 499993
Assignee: nobody → tglek
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.