Closed Bug 456106 Opened 15 years ago Closed 14 years ago

Switch to new drag and drop api in toolkit/browser

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

updated patch
73.27 KB, patch
asaf
: review+
Details | Diff | Splinter Review
Attached patch work in progress (obsolete) — — Splinter Review 
Need to write more tests.
Attached patch updated patch — — Splinter Review 
Tried to make some more tests but various event issues kept coming up. Will revisit this once this has been reviewed.
Attachment #339513 - Attachment is obsolete: true
Attachment #339828 - Flags: review?(mano)
Hey, sorry for the much delayed response here,

I couldn't find where's contentAreaDNDObserver.onDragOver is used.
(In reply to comment #2)
> Hey, sorry for the much delayed response here,
> 
> I couldn't find where's contentAreaDNDObserver.onDragOver is used.

Actually, it isn't used. The content area drag/drop is actually done in native code, but the browser for some reason, overrides the drop handler and handles links itself.
Comment on attachment 339828 [details] [diff] [review]
updated patch

r=mano for the parts that still apply. I'm ok with landing this in pieces if you're.
Attachment #339828 - Flags: review?(mano) → review+
http://hg.mozilla.org/mozilla-central/rev/5b8ff3412c80
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Did this possibly cause bug 503222 ?
Blocks: 504630
Depends on: 503754
Blocks: 773979
You need to log in before you can comment on or make changes to this bug.