"Alert translators" checkbox should only appear on English articles

VERIFIED FIXED in 0.7.1

Status

support.mozilla.org
Knowledge Base Software
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: cilias, Assigned: ecooper)

Tracking

unspecified
0.7.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tiki_bug, tiki_upstreamed)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Per discussion in bug 431501;
In the article editor, the "Alert translators" checkbox should only appear when editing an English article.

Updated

9 years ago
Assignee: nobody → smirkingsisyphus

Updated

9 years ago
Target Milestone: --- → 0.8
(Assignee)

Comment 1

9 years ago
Created attachment 341914 [details] [diff] [review]
patch for bug 456119

Instead of hardcoding 'en' as the language, it actually goes by the 'site language' preference, which in sumo is 'en'.
Attachment #341914 - Flags: review?(nelson)

Updated

9 years ago
Attachment #341914 - Flags: review?(nelson) → review-

Comment 2

9 years ago
Comment on attachment 341914 [details] [diff] [review]
patch for bug 456119

is it better to put the if outside the tr, so that you don't end up with an empty row if translation critical is not allowed?
(Assignee)

Comment 3

9 years ago
Created attachment 342115 [details] [diff] [review]
Eliminates empty tr when alert translators isn't allowed

Yeah. Initially, I separated it from the if statement controlling the row just to make it clear that it was a new addition, but I guess it's pretty trivial and unnecessary.

New patch adds the translation_alert_allowed bool check to the existing conditional controlling the row.
Attachment #341914 - Attachment is obsolete: true
Attachment #342115 - Flags: review?(nelson)

Updated

9 years ago
Attachment #342115 - Flags: review?(nelson) → review+

Comment 4

9 years ago
in r18905/r18906

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: 0.8 → 0.7.1
Verified FIXED on http://support-stage.mozilla.org/tiki-editpage.php?locale=fr&page=*Vider+l%27historique+de+la+barre+d%27adresse; I no longer see "Alerter les traducteurs:  	  Ceci est un article ayant subit une modification importante et qui doit être mise à jour dans les autres articles." as I do on production.
Status: RESOLVED → VERIFIED
Whiteboard: tiki_bug
Upstreamed with an option (feature_urgent_translation_master_only), disabled by default.
Whiteboard: tiki_bug → tiki_bug, tiki_upstreamed
You need to log in before you can comment on or make changes to this bug.