Larry is naked when SSL information is displayed

VERIFIED FIXED in fennec1.0a1

Status

Fennec Graveyard
General
P2
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: abillings, Assigned: mfinkle)

Tracking

({uiwanted})

Trunk
fennec1.0a1
x86
Linux
uiwanted
Bug Flags:
blocking-xul-fennec1.0 +

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
If a user goes to a site that is encrypted and selects the favicon to show Larry and site information, the text is drawn without a background, making it impossible to read in most instances.

This was seen in Stuart's build 20080918185520.

Steps to Reproduce
1. Go to http://www.verisign.com
2. Select the favicon

Result: Poor Naked Larry
(Reporter)

Comment 1

9 years ago
Created attachment 339537 [details]
screenshot

Updated

9 years ago
Assignee: nobody → mark.finkle
Flags: blocking-fennec1.0+
Priority: -- → P2
Target Milestone: --- → Fennec A1
Created attachment 340069 [details] [diff] [review]
explicitly set a theme for the identity panel

This patch uses the OS X style theming for the identity panel instead of letting the OS theme the panel.

We could pick a different color and transparency, but this is a start
Attachment #340069 - Flags: ui-review?
Attachment #340069 - Flags: review?(gavin.sharp)
Attachment #340069 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

9 years ago
Attachment #340069 - Flags: ui-review? → ui-review?(madhava)
(Assignee)

Updated

9 years ago
Attachment #340069 - Flags: ui-review?(madhava)
Created attachment 341063 [details] [diff] [review]
Colors patch current theme

Same as last patch, but the colors match to current theme and I removed unused CSS. Carrying gavin's r+

I'm landing this patch, but not resolving the bug so Madhava will be able see the theme and make suggestions. This is certainly better than a naked larry
Attachment #340069 - Attachment is obsolete: true
Attachment #341063 - Flags: review+
http://hg.mozilla.org/mobile-browser/rev/f4ee6a1d188c
(Assignee)

Updated

9 years ago
Keywords: uiwanted
Created attachment 341325 [details]
screenshot of dressed larry
Madhava gave his blessing, so I marking this fixed.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

9 years ago
Verified the new styled Larry with a 10/2 build.
(Reporter)

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.