456194 - "Approval Information" on version page should contain reviewer reply

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, enhancement, P5)

Description

[Dave Garrett]

Currently the "Approval Information" section of the page for managing a version/file contains the dates involved and the author's notes to the reviewer. This section should also contain notes from the reviewer to the author. The email you get after review contains the reviewer name, test system, and comments. This should all be in there along with the line giving the email and IRC room for questions.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: screenshot

This bug is talking about info to the dev page.  We can add the requested info in the "Approval Status" box pretty easily.  Jorge?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Agreed, that would be a really good thing to have for developers. I would recommend having the reviewer name, message, and a link to the amo-editors mailing list for questions.

Comment 3

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/a08a8a2

Comment 4

[krupa raj[:krupa]]

If a particular add-on file has multiple editor replies, we just show the first one.

steps to reproduce:
1. Load https://addons.allizom.org/en-US/editors/review/784139?num=10
2. Request more information for this version
3. Check that the editor reply gets added @ https://addons.allizom.org/en-US/developers/addon/adhaadhoora129/versions/784139
4. From editor tools, request super review
5. Check if the editor's response gets added to the versions details page.

expected behavior:
All editor replies are documented in version details page


actual behavior:
Only the first of editor replies are documented in the version details page.


Reopening..

Comment 5

[krupa raj[:krupa]]

Attachment: screenshot

Comment 6

[Gregory Koberger (:gkoberger)]

I just assumed we only wanted the most recent, since we only show one status.

However, I added in the full item history for the given file.

http://github.com/jbalogh/zamboni/commit/8cc122d

QA: Make sure it doesn't show the comments for private actions, such as "Request Super Review." (It shows there was a super review requested; just not the message.)

Comment 7

[krupa raj[:krupa]]

verified @ https://addons-next.allizom.org/en-US/developers/addon/blahblah123456/versions/1240086

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...