456212 - entrycompletion widget (awesome bar) grabs focus in a odd way

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Antonio Gomes (tonikitoo)]

Attachment: autocompletion widget on the top of system menu

1) open fennec and start typing something in the urlbar - autocomplete shows up.
2) keep it opened and tap something outside the fennec window (e.g. open another application or just tap a task navigation menu)

awesomebar keeps in the top of the screen (see screenshots #1 and #2), because of grabs focus wrongly.

Comment 1

[Stuart Parmenter]

is this focus or just zorder?

Comment 2

[Neil Deakin]

Looks like a rollup issue. The widget code should be rolling up popups when another application or system UI is used. Is the device not sending the right notifications, or am I possibly remembering that this wasn't always fully implemented on Linux?

Comment 3

[Antonio Gomes (tonikitoo)]

I believe this is a focus issue: see http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp#2867

we avoid the entrycompletion to grab the focus when vkb is up (otherwise double tap was needed to input from vkb - see bug 435885) , so it is probably the same case here: all 'child-windows" created are grabbing the focus that way...

Comment 4

[Neil Deakin]

Antonio, is this something you know how to fix?

Comment 5

[Antonio Gomes (tonikitoo)]

(In reply to comment #4)
> Antonio, is this something you know how to fix?

Neil, we could just avoid child windows to grab focus (as we did if vkb is up) in nsWindow.cpp if #HILDON.

stuart, mfinkle: is that something worth to do, even after after your discussion on #mobile about replacing autocomplete popup as it by a richlistbox or something else (no popup). If so , I could do that ...

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I think this is probably worked around by bug 466717?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Yeah, these issues go away with bug 466717 fixed.

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre