Closed Bug 456213 Opened 12 years ago Closed 12 years ago

-moz-transform matrix function with percentages confuses X and Y translate components.

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: kschwarz, Assigned: kschwarz)

References

Details

Attachments

(1 file)

There's a bug in nsStyleTransformMatrix where matrices that use percentage values in the final two components (to specify percentage translations) accidentally use the same value for the X and Y translations.  It's a minor typo (accessing element 5 of an array instead of element 6), so I'll post a patch that fixes the problem and adds a bunch of reftests to prevent regressions ASAP.
Blocks: 435293
Fixes the bad matrix index, and adds a bunch of reftests that should prevent regressions.
Attachment #339597 - Flags: superreview?(dbaron)
Attachment #339597 - Flags: review?(dbaron)
Attachment #339597 - Flags: superreview?(dbaron)
Attachment #339597 - Flags: superreview+
Attachment #339597 - Flags: review?(dbaron)
Attachment #339597 - Flags: review+
Comment on attachment 339597 [details] [diff] [review]
Potential Patch #1
[Checkin: Comment 3]

r+sr=dbaron
Attachment #339597 - Attachment description: Potential Patch #1 → Potential Patch #1 [Checkin: Comment 3]
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Keywords: checkin-needed
OS: Windows Vista → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.