456274 - On tinderbox waterfall, wanted leak report for test boxes too

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P5)

Description

[Serge Gautherie (:sgautherie)]

Bug 450983 comment 25:
{
From  Serge Gautherie   2008-09-09 19:03:26 PDT

As these leaks are not even reported on the waterfall itself [hint !],
[...]
}

***

Build boxes report RLk + Lk + MH + A.

Test boxes should report leaks for each of TUnit + ... + browser.
Currently, a box becomes Orange, but we have to open the (brief) report to discover why :-<

My proposal:
If |leak == threshold| (including "0"), no report ... That's the goal ;-)
If |leak != threshold|, add a report line like
"RLk: leak < threshold" (= green) or "RLk: leak > threshold" (= orange).

Comment 1

[(not currently active) Ted Mielczarek]

dupe of bug 445596?

Comment 2

[(not currently active) Ted Mielczarek]

Note that we don't track leaks in any of our test suites other than mochitest.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> dupe of bug 445596?

Right:
let's say that this is an enhanced output request, after minimal bug 445596 comment 1 ;->

(In reply to comment #2)
> Note that we don't track leaks in any of our test suites other than mochitest.

Well, let's apply it to where it can, of course ;-)

mochitest + chrome + browser:
Already leak tracked :-)

TUnit:
Could be (a little) harder as ("all") output does to their individual log files,
but it would be worse doing it (as I check them locally), as it does/can have leaks !

reftest + crashtest:
(I haven't run them yet, so I can't say, though I would think it couldn't hurt to monitor them too.)

Comment 4

[(not currently active) Ted Mielczarek]

Probably worth filing separate bugs for implementing leak tracking in TUnit and reftest.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Probably worth filing separate bugs for implementing leak tracking in TUnit and
> reftest.

I filed bug 456414.

Comment 6

[Serge Gautherie (:sgautherie)]

CC Marcia, as we briefly spoke about it at "Mozilla Camp Europe 2008".

Comment 7

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 8

[Chris Cooper [:coop] (he/him)]

If and when bug 456414 gets fixed, we'll implement support for it in buildbot, but we won't explicitly be adding support to tinderbox for it.