456276 - Default preview image shows on public page but not in lists

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Garrett]

For certain add-ons I'm seeing the default puzzle pieces image instead of their default preview when shown on the front page, category page, or in a search listing. (FF3 Get Add-ons searches are unaffected) Some scattered examples:
https://addons.mozilla.org/en-US/firefox/search?q=flagfox&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=fast+dial&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=firegestures&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=feed+sidebar&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=bugmenot&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=clipmarks&cat=all

This obviously sounds like another caching problem of some sort.

Comment 1

[Justin Scott [:fligtar]]

The preview system was re-done with Thursday's release which is probably causing this. Don't think it's caching.

Comment 2

[Justin Scott [:fligtar]]

Attachment: patch, v1

Because of the way the old preview manager worked, it was possible to have previews but none of them marked as the default. The revamp of the preview system assumed that one was marked as default, but that's not the case. So now, we'll take the default preview if available and if not, the oldest.

Comment 3

[Justin Scott [:fligtar]]

Attachment: patch, v2

forgot something important!

Comment 4

[Justin Scott [:fligtar]]

Fred, will you be able to review this before the freeze?

Comment 5

[Fred Wenzel [:wenzel]]

Comment on attachment 341709 [details] [diff] [review]
patch, v2

Sorry, how did that slip off my radar :(

I just tested it locally with "fast dial" and it fixed the problem as described.

Comment 6

[Justin Scott [:fligtar]]

Thanks, r19028.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/search?q=fast+dial&cat=all
https://preview.addons.mozilla.org/en-US/firefox/search?q=bugmenot&cat=all
https://preview.addons.mozilla.org/en-US/firefox/search?q=feed+sidebar&cat=all
https://preview.addons.mozilla.org/en-US/firefox/search?q=firegestures&cat=all