Default preview image shows on public page but not in lists

VERIFIED FIXED in 3.5

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: Dave Garrett, Assigned: fligtar)

Tracking

unspecified

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
For certain add-ons I'm seeing the default puzzle pieces image instead of their default preview when shown on the front page, category page, or in a search listing. (FF3 Get Add-ons searches are unaffected) Some scattered examples:
https://addons.mozilla.org/en-US/firefox/search?q=flagfox&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=fast+dial&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=firegestures&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=feed+sidebar&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=bugmenot&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=clipmarks&cat=all

This obviously sounds like another caching problem of some sort.
(Assignee)

Comment 1

10 years ago
The preview system was re-done with Thursday's release which is probably causing this. Don't think it's caching.
(Assignee)

Updated

10 years ago
Assignee: nobody → fligtar
Target Milestone: --- → 3.5
(Assignee)

Comment 2

10 years ago
Created attachment 341707 [details] [diff] [review]
patch, v1

Because of the way the old preview manager worked, it was possible to have previews but none of them marked as the default. The revamp of the preview system assumed that one was marked as default, but that's not the case. So now, we'll take the default preview if available and if not, the oldest.
Attachment #341707 - Flags: review?(fwenzel)
(Assignee)

Comment 3

10 years ago
Created attachment 341709 [details] [diff] [review]
patch, v2

forgot something important!
Attachment #341707 - Attachment is obsolete: true
Attachment #341709 - Flags: review?(fwenzel)
Attachment #341707 - Flags: review?(fwenzel)
(Assignee)

Comment 4

10 years ago
Fred, will you be able to review this before the freeze?

Comment 5

10 years ago
Comment on attachment 341709 [details] [diff] [review]
patch, v2

Sorry, how did that slip off my radar :(

I just tested it locally with "fast dial" and it fixed the problem as described.
Attachment #341709 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 6

10 years ago
Thanks, r19028.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED

Updated

10 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.