456349 - Clean up graphs

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Michael Morgan [:morgamic]]

Graphs are done using mochikit/plotkit, but there are better ways to generate these graphs -- google charts, flot, timeplot, or others are all viable alternatives with easier-to-use APIs.

Comment 1

[Austin King [:ozten]]

Attachment: Converting MochiKit to flot for plotting crash reports

To See new graph:
http://aking.khan.mozilla.org/reporter/report/list?query_search=signature&query_type=contains&query=nsChromeRegistry%3A%3ACheckForNewChrome()&date=&range_value=2&range_unit=weeks&do_query=1&signature=nsChromeRegistry%3A%3ACheckForNewChrome()

Comment 2

[Les Orchard [:lorchard]]

Comment on attachment 343111 [details] [diff] [review]
Converting MochiKit to flot for plotting crash reports

Works for me, but a few thoughts:

* In the reports controller, you're using foreach: and endforeach, which I usually only see in templates.  Might be better to use braces in controller code

* There's JS data constructed using string concatenation.  I think some of the original code was doing this, too.  It might be better to build a PHP data structure and then use json_encode() to produce this.  Often faster, and usually more resistant to XSS issues - though that shouldn't pop up in this particular bit of code.

Comment 3

[Austin King [:ozten]]

Updated foreach syntax. json_encode is a good idea. l.m.orchard thanks for the feedback, I will look at rolling that in soon. Code checked in r627.