Closed
Bug 456361
Opened 16 years ago
Closed 16 years ago
jarmaker leaves stale lockfiles when interrupted
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: Pike)
Details
Attachments
(2 files)
727 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
2.23 KB,
patch
|
Details | Diff | Splinter Review |
If you interrupt JarMaker when it has created a lockfile, the lockfile will stick around and hang your next attempt to build. You can reproduce this pretty easily by hitting Ctrl+C while a jar is being built.
Assignee | ||
Comment 1•16 years ago
|
||
Wrapping the while True: loop at http://mxr.mozilla.org/mozilla-central/source/config/JarMaker.py#271 with a try-finally and closing the jf if not-None should fix this. Taking.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•16 years ago
|
||
This is a diff -w for the change, I'll attach a regular patch for reference in a second. Requesting review on this one.
Attachment #339773 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 3•16 years ago
|
||
Reporter | ||
Updated•16 years ago
|
Attachment #339773 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Pushed, http://hg.mozilla.org/mozilla-central/rev/e9794a8b579d. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•