Closed Bug 456361 Opened 11 years ago Closed 11 years ago

jarmaker leaves stale lockfiles when interrupted

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: Pike)

Details

Attachments

(2 files)

If you interrupt JarMaker when it has created a lockfile, the lockfile will stick around and hang your next attempt to build. You can reproduce this pretty easily by hitting Ctrl+C while a jar is being built.
Wrapping the while True: loop at http://mxr.mozilla.org/mozilla-central/source/config/JarMaker.py#271 with a try-finally and closing the jf if not-None should fix this. Taking.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
This is a diff -w for the change, I'll attach a regular patch for reference in a second. Requesting review on this one.
Attachment #339773 - Flags: review?(ted.mielczarek)
Attachment #339773 - Flags: review?(ted.mielczarek) → review+
Pushed, http://hg.mozilla.org/mozilla-central/rev/e9794a8b579d. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.