jarmaker leaves stale lockfiles when interrupted

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: ted, Assigned: Pike)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
If you interrupt JarMaker when it has created a lockfile, the lockfile will stick around and hang your next attempt to build. You can reproduce this pretty easily by hitting Ctrl+C while a jar is being built.
(Assignee)

Comment 1

9 years ago
Wrapping the while True: loop at http://mxr.mozilla.org/mozilla-central/source/config/JarMaker.py#271 with a try-finally and closing the jf if not-None should fix this. Taking.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 years ago
Created attachment 339773 [details] [diff] [review]
add try-finally around the loop, adjust comment, patch -w

This is a diff -w for the change, I'll attach a regular patch for reference in a second. Requesting review on this one.
Attachment #339773 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

9 years ago
Created attachment 339775 [details] [diff] [review]
patch for check-in with indention changes
(Reporter)

Updated

9 years ago
Attachment #339773 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

9 years ago
Pushed, http://hg.mozilla.org/mozilla-central/rev/e9794a8b579d. Marking FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.