Closed
Bug 456362
Opened 16 years ago
Closed 16 years ago
Thunderbird3: Move Today Pane Button into Status Bar
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: chris.j.bugzilla, Assigned: Fallen)
Details
Attachments
(2 files, 4 obsolete files)
34.74 KB,
image/png
|
Fallen
:
ui-review+
|
Details |
15.94 KB,
patch
|
Details | Diff | Splinter Review |
The status bar should notify users about a current event. A button, located next to the "current event notification" opens the Today Pane. See proposal: https://wiki.mozilla.org/Thunderbird:Calendar_Integration#Today_Pane_Integration
Flags: tb-integration?
Updated•16 years ago
|
Flags: tb-integration? → tb-integration+
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•16 years ago
|
||
See also bug 257942
Updated•16 years ago
|
Flags: blocking-calendar1.0+
Assignee | ||
Comment 2•16 years ago
|
||
This patch takes care by putting the button into the statusbar. I used global icons for now, they should be replaced. How should the buttons be placed, in relation to the progressmeter, unread count, etc.
Attachment #342066 -
Flags: ui-review?(christian.jansen)
Attachment #342066 -
Flags: review?(Berend.Cornelius)
Reporter | ||
Comment 3•16 years ago
|
||
Good start :-) * Please add the small version of the Today Pane Icon in front of the "Date" * Replace the Date by the string "Today Pane" [1] * Add an expand/collapse icon right of "Today Pane" [1] I'm a bit unhappy with string "Today Pane". Any suggestions are welcome for a better name which sounds not so technical.
Assignee | ||
Comment 4•16 years ago
|
||
After encountering a bunch of issues related to the statusbar height, this finally fixes it, at least on gnome/linux without changing the statusbar height. I chose to not use the OS-styled buttons, but rather a flat button style since don't have a lot of room in that stausbar. The padding around the image and label is really tight, but given 17px (label+images) + 2px (border top/bottom) + 4px (border of statusbarpanel top/bottom) = 23px, we only have 1px left for the top and bottom padding. It seemed to work with 0.2pt top/bottom padding. Things may get better if the interactive statusbar proposed takes more room :-)
Attachment #342118 -
Flags: review?(Berend.Cornelius)
Assignee | ||
Updated•16 years ago
|
Attachment #342066 -
Attachment is obsolete: true
Attachment #342066 -
Flags: ui-review?(christian.jansen)
Attachment #342066 -
Flags: review?(Berend.Cornelius)
Assignee | ||
Comment 5•16 years ago
|
||
Attachment #342122 -
Flags: ui-review?(christian.jansen)
Comment 6•16 years ago
|
||
(In reply to comment #3) > I'm a bit unhappy with string "Today Pane". Any suggestions are welcome for > a better name which sounds not so technical. I like "Today Pane", but here are some more thoughts: Agenda Agenda Sidebar Today Today Sidebar Calendar Sidebar Or, depending on the user's current setting: "Events" | "Tasks" | "Events & Tasks" or "Today's Events" | "Today's Tasks" | "Today's Events & Tasks" In general I think that using the word "Today" at all is a little misleading because there are also sections for Tomorrow and Soon.
Comment 7•16 years ago
|
||
(In reply to comment #2) > How should the buttons be placed, in relation to the progressmeter, unread > count, etc. IMO the today-pane stuff should be on the rightmost part of the status bar, directly below the today pane.
Comment 8•16 years ago
|
||
(In reply to comment #3) > I'm a bit unhappy with string "Today Pane". Any suggestions are welcome for > a better name which sounds not so technical. Today's agenda Current agenda
Reporter | ||
Comment 9•16 years ago
|
||
(In reply to comment #4) > Created an attachment (id=342118) [details] > Add Today pane button - v2 > > After encountering a bunch of issues related to the statusbar height, this > finally fixes it, at least on gnome/linux without changing the statusbar > height. I chose to not use the OS-styled buttons, but rather a flat button > style since don't have a lot of room in that stausbar. > > The padding around the image and label is really tight, but given 17px > (label+images) + 2px (border top/bottom) + 4px (border of statusbarpanel > top/bottom) = 23px, we only have 1px left for the top and bottom padding. It > seemed to work with 0.2pt top/bottom padding. > > Things may get better if the interactive statusbar proposed takes more room :-) IMO it is OK to gain a little bit in vertical space. This would help clicking the button more easily. I think your solution is good, but I'd like to suggest some ideas for some fine tuning (see attachment): - Please remove the 3D effect of the border I think it is OK to draw it flat - I agree to Pete, the button should be placed on the rightmost part - It would also be great if you could add some rounded border to the box - would it be possible to align the "button" vertically? Momentarily it sticks at the top of the status bar - I think it makes sense to increase the padding left of the icon to at least 2px
Reporter | ||
Comment 10•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Attachment #342122 -
Attachment is obsolete: true
Attachment #342122 -
Flags: ui-review?(christian.jansen)
Assignee | ||
Comment 11•16 years ago
|
||
Comment on attachment 342212 [details]
Fine tuned Today Pane Status Bar Button
I took care of christian's comments and we figured out the last bits in the office.
Attachment #342212 -
Flags: ui-review+
Assignee | ||
Comment 12•16 years ago
|
||
Attachment #342118 -
Attachment is obsolete: true
Attachment #342221 -
Flags: review?(Berend.Cornelius)
Attachment #342118 -
Flags: review?(Berend.Cornelius)
Comment 13•16 years ago
|
||
Comment on attachment 342221 [details] [diff] [review] Add Today pane button - v3 The patch solves the issue in a very elegant way and does not leave much to complain about. As we have already discussed my personal opinion is that we should move all code that could possibly be used by Sunbird too into the base folder instead of the lightning -even if we create some overhead in that application at first. But this is just my opinion... Similar goes for the lightning resources. Instead of creating a new resource you could also use the existing entities in calendar.dtd. >+#calendar-status-todaypane-button, >+#calendar-status-todaypane-button[checked="true"] { >+ min-width: 0; >+ min-height: 0; >+ -moz-appearance: none; >+ -moz-border-radius: 3px; >+ padding: 0.2pt 2px !important; >+ border: 1px solid transparent; >+} >+ >+#calendar-status-todaypane-button:hover { >+ border: 1px solid ThreeDShadow; >+ background-color: transparent !important; >+ background-image: none; >+ -moz-appearance: none; >+} Some entries in these rules seem redundant or dispensable to me. r=berend.
Attachment #342221 -
Flags: review?(Berend.Cornelius) → review+
Comment 14•16 years ago
|
||
I unbitrotted the patch so that it should apply again
Attachment #342221 -
Attachment is obsolete: true
Assignee | ||
Comment 15•16 years ago
|
||
> As we have already discussed my personal opinion is that we should move all > code that could possibly be used by Sunbird too into the base folder instead of > the lightning -even if we create some overhead in that application at first. I disagree as you probably know ;-) Its trivial to move over resources if the today pane is implemented in sunbird and until then I don't think it makes sense to make the resources shared between apps, because I don't think we will remember to clean up in case some resources are *not* used when implementing the today pane. > Similar goes for the lightning resources. Instead of creating a new resource > you could also use the existing entities in calendar.dtd. I was thinking of using this resource, but the string name doesn't really make sense, since this is nothing that belongs to any context menu. > Some entries in these rules seem redundant or dispensable to me. I would have hoped so too, but due to some toolkit rules this is the minimal set. Thanks for debitrotting the patch! I've noticed that after the tabbing patch, the today pane is no longer visible in mail mode but I think this is not something caused by my patch.
Assignee | ||
Comment 16•16 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f538f6949e42> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: uiwanted
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Comment 17•16 years ago
|
||
Yes, the tabbing patch moved all the calendar content, including the today pane, into its own tab panel. If you want to show the today pane, you would want to force a switch to the calendar tab, most likely. tabmail.openTab("calendar") would accomplish this, where tabmail is retrieved by getting the element with id "tabmail". (Note that the exact semantics here are to try and open a new calendar tab, but since the tab code limits you to 1 calendar tab, if one already exists, it will simply be shown. This might have undesirable ramifications when you can open more than one calendar tab...)
Comment 18•16 years ago
|
||
Hmm, I think this undermines the today pane's foremost purpose: offer a small summary pane of what's happening. Most users like it exactly for the reason they don't have to leave mail to track their day.
Comment 19•16 years ago
|
||
(In reply to comment #18) > Hmm, I think this undermines the today pane's foremost purpose: offer a small > summary pane of what's happening. Most users like it exactly for the reason Yeah, that was not a permanent change made for UX reasons so much as a temporary change for structuring reasons so intentional UX decisions can build on something sane. The way lightning contributed its sidebars was necessarily hackish, but not scalable. For example, with expmess and lightning installed, I had two right sidebars; it was pretty crazy and would have been unusable had a third extension decided to contribute another sidebar. I presumed what we want is either an explicit tabbed side-bar mechanism (possibly like myk's experiment at http://www.melez.com/mykzilla/2008/10/easier-access-to-sidebars.html) or just a single 'smart' sidebar made up of magical context-sensitive widgets or something. Thunderbird core chrome needs to provide an explicit mechanism that lightning can build on to meet our shared UX goals (which I myself am not yet well-informed of, so I just went for a clean initial factoring.) I eagerly await UX wisdom/pointers to already-existing UX wisdom from clarkbw and others :).
Comment 20•16 years ago
|
||
VERIFIED FIXED using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081127 Lightning/1.0pre Shredder/3.0b1pre.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 21•13 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•