456389 - Implement JS 1.8 reduce/reduceRight array methods

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Hannes Wallnoefer]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1
Build Identifier: 

Implement JavaScript 1.8 reduce/reduceRight array methods. See bug #363040 for spicermonkey implementation.

Reproducible: Always

Comment 1

[Hannes Wallnoefer]

Attachment: Implements reduce/reduceRight methods

Implements reduce and reduceRight methods on array prototype and constructor. I tried to reproduce the behaviour of spidermonkey, especially for sparse/empty arrays.

Comment 2

[Hannes Wallnoefer]

Attachment: improved patch

Patch with minor improvements and fixes.

Comment 3

[Hannes Wallnoefer]

Committed the last patch to CVS HEAD:

Checking in src/org/mozilla/javascript/NativeArray.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeArray.java,v  <--  NativeArray.java
new revision: 1.97; previous revision: 1.96
done
Checking in src/org/mozilla/javascript/resources/Messages.properties;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/resources/Messages.properties,v  <--  Messages.properties
new revision: 1.91; previous revision: 1.90
done

Comment 4

[rspeyer]

Attachment: reduce and reduceRight throw a TypeError when array empty and no initVal

As per 15.4.4.21 step 5, and 15.4.4.22 step 5 of the spec.

Comment 5

[Norris Boyd]

(In reply to comment #4)
> Created an attachment (id=391093) [details]
> reduce and reduceRight throw a TypeError when array empty and no initVal
> 
> As per 15.4.4.21 step 5, and 15.4.4.22 step 5 of the spec.

Committed:

Checking in src/org/mozilla/javascript/NativeArray.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeArray.java,v  <--  NativeArray.java
new revision: 1.105; previous revision: 1.104

Comment 6

[rspeyer]

Attachment: made reduceRight pass the correct (descending) index to the callback function