456390 - move control strip buttons into position

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

The buttons in the control strip are all there, but not in the arrangement as in the mockups.  This arrangement would be great:

http://blog.seanmartell.com/wp-content/uploads/2008/09/fennec_screen_3.jpg

if you need actual pixel positions, just ask!

Comment 1

[Daniel Brooks [:db48x]]

Attachment: 456390-1.diff

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 339922 [details] [diff] [review]
456390-1.diff

>diff -r 0ff13ee6bc34 chrome/content/browser-ui.js
>       sidebar.left = containerW;
>-      sidebar.height = panelUI.height = tabbar.height = containerH;
>+      sidebar.height = (panelUI.height = tabbar.height = containerH) - toolbarH;

Actually, tabbar.height should be (containerH - toolbarH) too. We changed it and I missed this. Only panelUI.height is containerH now.

r+ with that

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 339922 [details] [diff] [review]
456390-1.diff

>diff -r 0ff13ee6bc34 chrome/content/browser-ui.js

>-      sidebar.height = panelUI.height = tabbar.height = containerH;
>+      sidebar.height = (panelUI.height = tabbar.height = containerH) - toolbarH;

Shouldn't all of these be the same height?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

nm, I missed mark's comment!

Comment 5

[Daniel Brooks [:db48x]]

pushed revision 055149dd6e52

Comment 6

[Aakash Desai [:aakashd]]

easy bug to verify :). Verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre