move control strip buttons into position

VERIFIED FIXED in fennec1.0a1

Status

defect
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: madhava, Assigned: db48x)

Tracking

Trunk
fennec1.0a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The buttons in the control strip are all there, but not in the arrangement as in the mockups.  This arrangement would be great:

http://blog.seanmartell.com/wp-content/uploads/2008/09/fennec_screen_3.jpg

if you need actual pixel positions, just ask!
Posted patch 456390-1.diffSplinter Review
Assignee: gavin.sharp → db48x
Status: NEW → ASSIGNED
Attachment #339922 - Flags: review?
Attachment #339922 - Flags: review? → review?(gavin.sharp)
Comment on attachment 339922 [details] [diff] [review]
456390-1.diff

>diff -r 0ff13ee6bc34 chrome/content/browser-ui.js
>       sidebar.left = containerW;
>-      sidebar.height = panelUI.height = tabbar.height = containerH;
>+      sidebar.height = (panelUI.height = tabbar.height = containerH) - toolbarH;

Actually, tabbar.height should be (containerH - toolbarH) too. We changed it and I missed this. Only panelUI.height is containerH now.

r+ with that
Attachment #339922 - Flags: review?(gavin.sharp) → review+
Comment on attachment 339922 [details] [diff] [review]
456390-1.diff

>diff -r 0ff13ee6bc34 chrome/content/browser-ui.js

>-      sidebar.height = panelUI.height = tabbar.height = containerH;
>+      sidebar.height = (panelUI.height = tabbar.height = containerH) - toolbarH;

Shouldn't all of these be the same height?
nm, I missed mark's comment!
pushed revision 055149dd6e52
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
easy bug to verify :). Verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.