Closed Bug 456467 Opened 13 years ago Closed 13 years ago

revisit cairo xlib buggy repeat handling

Categories

(Core :: Graphics, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

We unconditionally set buggy-repeat to true, due to the issues discussed in bug 413583.  xorg 1.5 is out now, and presumably doesn't contain this bug -- we should not be setting it to on for xorg >= 1.5.
Flags: blocking1.9.1+
This patch essentially undoes the old buggy-repeat forcing, but keeps an env var so that we can easily test to see if we're hitting this bug.  The old patch went in before we correctly detected xorg 1.4 as good, so I think we're ok to trust the normal cairo detection (which is basically buggy-repeat ON for any xorg/xfree86 server before xorg 1.4; default OFF for any other server).
Attachment #340026 - Flags: review?(roc)
Comment on attachment 340026 [details] [diff] [review]
new buggy-repeat patch

+        buggy_repeat_force = -2
+

what rubbish compiler are you using?

+        display->buggy_repeat = buggy_repeat_force ? TRUE : FALSE;

buggy_repeat_force == 1
Attachment #340026 - Flags: review?(roc) → review+
(In reply to comment #2)
> (From update of attachment 340026 [details] [diff] [review])
> +        buggy_repeat_force = -2
> 
> what rubbish compiler are you using?

Gah, the one where I accidentally typed some crap in my buffer and backspaced over too much before refreshing the patch.

> +        display->buggy_repeat = buggy_repeat_force ? TRUE : FALSE;
> buggy_repeat_force == 1

K, changed.
http://hg.mozilla.org/mozilla-central/rev/5a9c08494f58 Vladimir Vukicevic - b=456467; revisit cairo xlib buggy repeat handling; r=roc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.