Closed Bug 456471 Opened 11 years ago Closed 11 years ago

mozIStorageError IDL file needs ERROR undefined for WinCE / WinMobile

Categories

(Toolkit :: Storage, defect)

ARM
Windows Mobile 6 Professional
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfe, Unassigned)

Details

(Keywords: mobile)

Attachments

(1 file, 1 obsolete file)

Keywords like ERROR and INTERNAL can not be used by programs compiled with Visual Studio 2008 (VS9) - so this processed IDL file's header causes the WinCE build to break.

Unfortunately, the answer is to change some constants in the IDL file...
Attachment #339869 - Flags: review?(sdwilsh)
Component: General → Storage
Product: Fennec → Toolkit
QA Contact: general → storage
mfinkle pointed out how I really only need to undefine ERROR for this compile problem - and the IDL's generated header file works fine!

Adding a new patch next.
Summary: mozIStorageError IDL file uses keywords for WinCE Compiler → mozIStorageError IDL file needs ERROR undefined for WinCE / WinMobile
I owe mfinkle a beer for his great pointer to this much simpler solution to my compiler error.  

This type of solution is also used in nsIDOMNSEvent.idl (line 41)
Attachment #339869 - Attachment is obsolete: true
Attachment #339899 - Flags: review?(sdwilsh)
Attachment #339869 - Flags: review?(sdwilsh)
Attachment #339899 - Attachment is patch: true
Attachment #339899 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 339899 [details] [diff] [review]
Only ERROR needs underfining for WinCE / WinMobile Compiler to work

Ah good; I like this patch much better.

r=sdwilsh, but you need to add a comment above that block explaining why please.
Attachment #339899 - Flags: review?(sdwilsh) → review+
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.