Closed
Bug 456484
Opened 17 years ago
Closed 17 years ago
Inside block shrinkwraps when outside inline-block has scrollframe
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: bzbarsky)
References
Details
(Keywords: testcase)
Attachments
(3 files)
|
346 bytes,
text/html
|
Details | |
|
330 bytes,
text/html
|
Details | |
|
735 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
See testcase, I would expect it to render the same as the reference rendering (which I'm going to attach).
The only difference between the two is the addition of overflow: auto in the testcase.
| Reporter | ||
Comment 1•17 years ago
|
||
| Assignee | ||
Comment 2•17 years ago
|
||
So the issue is that moz-scrolled-content inherits the display... Should we instead be unconditionally setting it to display:block? That wouldn't affect scrolled blocks, would improve scrolled inline-blocks. The only question is what would happen with scrolled table-row-groups, but I think that should be ok.
| Assignee | ||
Comment 3•17 years ago
|
||
Attachment #341404 -
Flags: superreview?(roc)
Attachment #341404 -
Flags: review?(roc)
Comment on attachment 341404 [details] [diff] [review]
Like so
You may wish to add a comment mentioning that this does not affect the type of frame created --- we always create the scrolled frame based on the real 'display' value of the element. So this is really just to satisfy code that checks whether the nsBlockFrame is inline-level.
Attachment #341404 -
Flags: superreview?(roc)
Attachment #341404 -
Flags: superreview+
Attachment #341404 -
Flags: review?(roc)
Attachment #341404 -
Flags: review+
| Assignee | ||
Comment 5•17 years ago
|
||
Pushed changeset d28eb3aa049d with the comment change and the tests.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
| Assignee | ||
Updated•15 years ago
|
Assignee: nobody → bzbarsky
You need to log in
before you can comment on or make changes to this bug.
Description
•