456531 - Icons in the bookmarks menu need padding on the right side

Status: RESOLVED INVALID

(Firefox :: Menus, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Bookmarks menu in Firefox 3 and native, 500%

Current there is only 1 pixel of padding on the right side of icons.  Since the native menus are also misaligned (too much padding as opposed to too little), how about we just match the padding on the left side, and have 4 pixels on either side of the icon.

Comment 1

[Victor Bielawski]

What you call native is in fact ownerdrawn since around IE 4. Try the Page menu in IE 8 for Vista for truly native iconic menus.

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Are there any actually native menus on XP that contain icons that we can use to determine the correct padding levels there?

Comment 3

[Victor Bielawski]

On XP there is no native iconic menu API. The best bet looks like IE8's Page menu, or the Start menu in small icon mode.

Comment 4

[George K.]

What about the "New" menu when seen when right-clicking in a folder or on the desktop or selecting "File > New"?

It's 8 px left padding, 16 px icon, 6 px right padding.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Andy from comment #4)
> What about the "New" menu when seen when right-clicking in a folder or on
> the desktop or selecting "File > New"?
> 
> It's 8 px left padding, 16 px icon, 6 px right padding.

This is what I see on Firefox as well.

The hover styling for these menuitems leaves 6px of padding on each side of the icon (not including the space outside the hover outline).