456595 - Plain readonly textboxes should have a transparent background

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Florian Quèze [:florian]]

Attachment: Simple patch

Read-only textboxes are often used to allow the user to select the content, and copy/paste/use the context menu.

The plain style class of textboxes is used to display a textbox with no border or margin.

When a readonly textbox has the class plain, on Mac the background color (-moz-Dialog, set by the style rule for textbox[readonly="true"]) of the textbox is visible. On Linux and Windows, this is usually not the case because -moz-Dialog tends to match the background color of most windows.

I think this background should be transparent.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Where (i.e. which product/UI) has this come up as an issue?

Comment 2

[Florian Quèze [:florian]]

Attachment: Same patch for all 3 OSes

Actually, with non default OS themes, I can see this on Windows and Linux too.

(In reply to comment #1)
> Where (i.e. which product/UI) has this come up as an issue?

Currently I have it in 2 different places in Instantbird but I originally saw this in Firefox.

A few examples in Firefox:
 - The bottom of the View Cookies dialog
 - The textbox at the bottom of the Application Details dialog (from the Applications tab of the Preference dialog)

I think it's also visible in DOM Inspector but I haven't checked right now.

I was pretty sure it used to be an issue in Page Info too but I just checked and saw that the code doesn't use the class plain and duplicates the '-moz-appareance: none' style rule instead.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I think one of the Neils would probably be a better reviewer for this.

Comment 4

[Florian Quèze [:florian]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/a269caae011a