456670 - Once five tabs are open, the UI to open tabs is pushed off screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Al Billings [:abillings - ex-MoCo]]

Attachment: screenshot of bug

If a user uses the tab button in the left pannel to open four tabs (beyond the original first tab), the tab button (and the weave button next to it) are pushed off of the bottom of the UI, never to return. There is no way to get them back since, as a separate issue, there is no way to close a tab. 

See attached screenshot.

This was found in the A8 build (20080923171103).

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Wait a minute. You got more than 5 tabs to open? Hurray!

Closing a tab (bug 454667) is waiting for review

But to solve this issue, we talked about making the tabbar width get larger to hold more "columns" of tabs.

Comment 2

[Al Billings [:abillings - ex-MoCo]]

Whether you have 5 or 15 tabs open, you probably want to be able to open more at your discretion. :-)

Comment 3

[Madhava Enros [:madhava]]

Bah - four tabs ought to be enough for everybody. :)

What Finkle said in comment 1 -- when we exceed four thumbnails, we go to having two columns of tab thumbnails.  Because the tab area snaps out into place, it shouldn't require any more dragging to get the larger area out than the smaller one.

Beyond that point, I'm not sure.  We've made a decision to have this area not be pannable -- two independently panning areas next to each other seems like it would be hard to navigate to me, and it opens up a lot of problems.  We can try shrinking thumbnails up to a point.

Comment 4

[Neil Deakin]

Attachment: support tabs in multiple rows

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 343414 [details] [diff] [review]
support tabs in multiple rows

Something not quite right when removing tabs:
* add enough tabs to get 2 columns
* remove a tab from the first column
* thumbnails are missing from all tabs "after" the removed tab.

The tabs themselves seem to be there and the remove button for the "missing" tabs is drawn. It's just the canvas that doesn't seem to be there (or isn't drawn)

Comment 6

[Antonio Gomes (tonikitoo)]

Have two rows of thumbnails really do look good on reduced size screens ... truly ... even worse if it is possible to get a third row.

I would suggest either:

1) a single pannable/scrollable row (maybe panning in sync w/ the page content ... maybe not).

2) to avoid thumbnails to get offscreen, once the row is "full" , start  getting smaller thumbnails when new tabs are added to fit to the single a constant row size.

what do you think ?

Comment 7

[Neil Deakin]

Attachment: redraw tabs after moving them

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (X11; U; Linux armv6I; en-US; rv:1.9.1b2pre) Gecko/20081113 Fennec/1.0a2pre.