456680 - aero-news.net - Flash version detection script broken in all Mozilla browsers

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English US, defect)

Description

[Chris Lawson (gone)]

The Flash version-detection script on the site is broken in all browsers that use navigator.plugins (Firefox, Camino, Seamonkey, Safari, etc. -- basically everything except IE).

The line

var flashVersion = parseInt(flashDescription.charAt(flashDescription.indexOf(".") - 1));

will fail (obviously) with any Flash version that contains two digits.

Using charAt() won't work here, since it only gets a single character and Flash versions can now have two digits. I'd personally use a substr() call, like this:

var flashVersion = parseInt(flashDescription.substr((flashDescription.indexOf(".") - 2)), 2);

That should take care of it as long as they don't ever have to do more sophisticated Flash version-sniffing based on the sub-release (r12, in this case; there were about five or six major sub-releases of Flash 9).

I've also e-mailed the above to [e-mail].

Comment 1

[Gary Kuanoni]

I'm sorry, can you translate into basic english what I need to do to fix.

Comment 2

[Chris Lawson (gone)]

(In reply to comment #1)
> I'm sorry, can you translate into basic english what I need to do to fix.

Since you aren't the webmaster of either this site or the other site (in bug 464085), there isn't anything you can do except continue complaining to the folks who *can* do something (i.e., the webmasters).

Comment 3

[Gary Kuanoni]

OK, thanks I understand now.

Comment 4

[RNicoletto]

Aero-News had been updated and it's WFM.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12