Closed Bug 456694 Opened 13 years ago Closed 12 years ago

Remove obsolete(d) <nsTreeController.js>

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

Either our |var treeController = new nsTreeController(gHistoryTree);| is useless ? (At least the var part ?)

Or we should:
1. Move nsTreeController.js to /suite
2a. Make that var a global variable;
2b. Make nsTreeController remove its controller on unload.
   http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/obsolete/content/nsTreeController.js?mark=222#218
Blocks: 456672
(In reply to comment #0)
> (At least the var part ?)

I'll handle this in bug 456672.

> 1. Move nsTreeController.js to /suite

Only this part applies.
Neil, do you agree with this part ?

> 2a. Make that var a global variable;
> 2b. Make nsTreeController remove its controller on unload.

Unneeded, per bug 415775.
Blocks: 415775
No longer blocks: 456672
Severity: minor → trivial
Depends on: 456672
Summary: Improve history.js <-> nsTreeController.js relation → Move toolkit <nsTreeController.js> to /suite
AFAIK, history.js needs a huge rework for bug 382187, so I would check that it's still needed afterwards before moving code from toolkit to suite.
Sure. Getting rid of this last occurrence would be even better ;-)
Depends on: 382187
Bug 382187 replaced the last user.
Assignee: build-config → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #352942 - Flags: superreview?(mconnor)
Attachment #352942 - Flags: review?(mconnor)
Product: SeaMonkey → Toolkit
Summary: Move toolkit <nsTreeController.js> to /suite → Remove obsolete(d) <nsTreeController.js>
Target Milestone: --- → mozilla1.9.2a1
Attachment #352942 - Flags: superreview?(vladimir)
Attachment #352942 - Flags: superreview?(mconnor)
Attachment #352942 - Flags: review?(vladimir)
Comment on attachment 352942 [details] [diff] [review]
(Av1) Remove obsolete(!) file
[Checkin: Comment 7]

Looking for r+sr !
Attachment #352942 - Flags: superreview?(vladimir)
Attachment #352942 - Flags: superreview+
Attachment #352942 - Flags: review?(vladimir)
Attachment #352942 - Flags: review?(mconnor)
Attachment #352942 - Flags: review+
Comment on attachment 352942 [details] [diff] [review]
(Av1) Remove obsolete(!) file
[Checkin: Comment 7]

yeah, this is fine to go on trunk, we don't use it anywhere now.  just don't put it in 1.9.1...
Comment on attachment 352942 [details] [diff] [review]
(Av1) Remove obsolete(!) file
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/0db9852da025
Attachment #352942 - Attachment description: (Av1) Remove obsolete(!) file → (Av1) Remove obsolete(!) file [Checkin: Comment 7]
(In reply to comment #6)
> we don't use it anywhere now.  just don't put it in 1.9.1...

1.9.1 doesn't use it anymore either ... but as you say :-|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Extensions might, for some reason, use it.  Not worth the risk at this late stage for a 1k win on download size.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.