456694 - Remove obsolete(d) <nsTreeController.js>

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

Either our |var treeController = new nsTreeController(gHistoryTree);| is useless ? (At least the var part ?)

Or we should:
1. Move nsTreeController.js to /suite
2a. Make that var a global variable;
2b. Make nsTreeController remove its controller on unload.
   http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/obsolete/content/nsTreeController.js?mark=222#218

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> (At least the var part ?)

I'll handle this in bug 456672.

> 1. Move nsTreeController.js to /suite

Only this part applies.
Neil, do you agree with this part ?

> 2a. Make that var a global variable;
> 2b. Make nsTreeController remove its controller on unload.

Unneeded, per bug 415775.

Comment 2

[Robert Kaiser]

AFAIK, history.js needs a huge rework for bug 382187, so I would check that it's still needed afterwards before moving code from toolkit to suite.

Comment 3

[Serge Gautherie (:sgautherie)]

Sure. Getting rid of this last occurrence would be even better ;-)

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove obsolete(!) file [Checkin: Comment 7]

Bug 382187 replaced the last user.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 352942 [details] [diff] [review]
(Av1) Remove obsolete(!) file
[Checkin: Comment 7]

Looking for r+sr !

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 352942 [details] [diff] [review]
(Av1) Remove obsolete(!) file
[Checkin: Comment 7]

yeah, this is fine to go on trunk, we don't use it anywhere now.  just don't put it in 1.9.1...

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 352942 [details] [diff] [review]
(Av1) Remove obsolete(!) file
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/0db9852da025

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> we don't use it anywhere now.  just don't put it in 1.9.1...

1.9.1 doesn't use it anymore either ... but as you say :-|

Comment 9

[Mike Connor [:mconnor]]

Extensions might, for some reason, use it.  Not worth the risk at this late stage for a 1k win on download size.