Closed
Bug 456792
Opened 16 years ago
Closed 16 years ago
Two more API cleanups for nsCSSRendering
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: zwol, Assigned: zwol)
Details
Attachments
(2 files)
12.19 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
21.42 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Here's two more API cleanup patches for nsCSSRendering. The first removes the completely unused nsStylePadding argument from PaintBackgroundWithSC and its subroutine PaintBackgroundColor. I should have caught this when I did the previous cycle of argument removals from PaintBackground; apologies. The second notes that as class nsCSSRendering is a fake namespace, there is no reason for it to have protected functions, and turns them into static functions in nsCSSRendering.cpp.
Attachment #340160 -
Flags: review?(roc)
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #340161 -
Flags: review?(roc)
Attachment #340160 -
Flags: superreview+
Attachment #340160 -
Flags: review?(roc)
Attachment #340160 -
Flags: review+
Attachment #340161 -
Flags: superreview+
Attachment #340161 -
Flags: review?(roc)
Attachment #340161 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 2•16 years ago
|
||
Comment on attachment 340160 [details] [diff] [review] patch 1: remove unused padding arg [Checkin: Comment 2] http://hg.mozilla.org/mozilla-central/rev/182489ec31e8
Attachment #340160 -
Attachment description: patch 1: remove unused padding arg → patch 1: remove unused padding arg
[Checkin: Comment 2]
Comment 3•16 years ago
|
||
Comment on attachment 340161 [details] [diff] [review] patch 2: hide nsCSSRendering private functions [Checkin: Comment 4] http://hg.mozilla.org/mozilla-central/rev/d01bc28978cd
Attachment #340161 -
Attachment description: patch 2: hide nsCSSRendering private functions → patch 2: hide nsCSSRendering private functions
[Checkin: Comment 3]
Comment 4•16 years ago
|
||
Comment on attachment 340161 [details] [diff] [review] patch 2: hide nsCSSRendering private functions [Checkin: Comment 4] (In reply to comment #3) > http://hg.mozilla.org/mozilla-central/rev/d01bc28978cd http://hg.mozilla.org/mozilla-central/rev/b14496f9fb7a !
Attachment #340161 -
Attachment description: patch 2: hide nsCSSRendering private functions
[Checkin: Comment 3] → patch 2: hide nsCSSRendering private functions
[Checkin: Comment 4]
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
Assignee | ||
Comment 5•16 years ago
|
||
That was fast; thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•