Closed Bug 456792 Opened 16 years ago Closed 16 years ago

Two more API cleanups for nsCSSRendering

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: zwol, Assigned: zwol)

Details

Attachments

(2 files)

Here's two more API cleanup patches for nsCSSRendering.

The first removes the completely unused nsStylePadding argument from PaintBackgroundWithSC and its subroutine PaintBackgroundColor.  I should have caught this when I did the previous cycle of argument removals from PaintBackground; apologies.

The second notes that as class nsCSSRendering is a fake namespace, there is no reason for it to have protected functions, and turns them into static functions in nsCSSRendering.cpp.
Attachment #340160 - Flags: review?(roc)
Keywords: checkin-needed
Comment on attachment 340160 [details] [diff] [review]
patch 1: remove unused padding arg
[Checkin: Comment 2]

http://hg.mozilla.org/mozilla-central/rev/182489ec31e8
Attachment #340160 - Attachment description: patch 1: remove unused padding arg → patch 1: remove unused padding arg [Checkin: Comment 2]
Comment on attachment 340161 [details] [diff] [review]
patch 2: hide nsCSSRendering private functions
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/d01bc28978cd
Attachment #340161 - Attachment description: patch 2: hide nsCSSRendering private functions → patch 2: hide nsCSSRendering private functions [Checkin: Comment 3]
Comment on attachment 340161 [details] [diff] [review]
patch 2: hide nsCSSRendering private functions
[Checkin: Comment 4]

(In reply to comment #3)
> http://hg.mozilla.org/mozilla-central/rev/d01bc28978cd

http://hg.mozilla.org/mozilla-central/rev/b14496f9fb7a !
Attachment #340161 - Attachment description: patch 2: hide nsCSSRendering private functions [Checkin: Comment 3] → patch 2: hide nsCSSRendering private functions [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
That was fast; thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: