456840 - messagereader: allow easy removing of contact from address book

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[David Ascher (:davida)]

maybe some UI in the contact editing panel?

Comment 1

[Phil Ringnalda (:philor)]

That's where I'd expect it from the Fx parallel - accidentally bookmark, click the star again, [Remove Bookmark] is rather too familiar to me.

(Though as the painful position of [Remove Bookmark] shows, it's not an easy thing to fit in.)

Comment 3

[dreadnaut]

Alternative solutions that come to my mind:

 * add a "remove contact" button to the editing panel, as in Firefox (Fx does not ask for confirmation, while Thunderbird probably should, at least if more data has been added since the contact creation);

 * add a "remove contact" entry in the context menu (with confirmation) - less visual clutter;

 * add a "Show in address book" entry in the context menu - speeds up deletion (compared to the current interface), but also group/list handling.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: delete contact item to the editContactOverlay

I just did this up while I was waiting for Windows to rebuild.  I'll upload the patch in a second.  ( Delete ) sounds a bit too strong so I was thinking about going with ( Remove Contact ) however we use ( Delete ) everywhere else in the interface.  There is a confirm dialog for this just to prevent people from deleting a contact (which may have other data) too quickly.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: add delete button to the editContactOverlay

Only quirk to this patch is that when the confirm dialog appears I hide the editContactOverly; this is done because otherwise the popup would steal the first click and make it seem like the dialog lost a click.  It would be nice to re-show the dialog after canceling delete but if I wanted a chance of sneaking this in I need to get reviewed now for strings.

asking review from standard8 since he did the original

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Also, I only did the theme for Mac right now.  I'll get the other themes finished but I wanted to get a review of the code on radar if possible.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 403538 [details] [diff] [review]
add delete button to the editContactOverlay

r=Standard8. If you can get someone else to check Win/Linux themes (to save me some time) that'd be great.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of vista delete contact

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

magnus: would you have a chance to check this on linux?  My Linux machine is busted right now.  I expect that it should look just like the other buttons.

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of linux delete button

did some testing on my Linux VM and seems to work out fine

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 403538 [details] [diff] [review]
add delete button to the editContactOverlay

tested it out on all 3 platforms so looking to see if we can get this in.

Comment 12

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/98ec2b48d11d

Comment 13

[Peter Lairo]

Top-left is an odd place for an UI button, especially when all the other buttons are along the bottom.

Would it be better to make the dialog slightly wider, and put the Delete button between the Edit and Cancel buttons, with more space between Delete and Cancel?

Comment 14

[Magnus Melin [:mkmelin]]

Filed bug 520211 about that.