Closed Bug 456894 Opened 13 years ago Closed 13 years ago
.py can't handle negative leaks
While investigating some failures, I found some cases where runtests.py complains "missing output line for total leaks!", when it's clearly in the output. Example from http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1221925353.1221933011.32720.gz&fulltext=1#err46 Scroll up and you'll find: 0 TOTAL -4 63920 -1005666652 .... Looks like the problem is the regex runtests.py uses to find the "TOTAL" line. It's not expecting negative numbers. dbaron says this can happen when bogus addref/release patterns confuse tracerefcount. The script should catch these, and handle as a "omgwtf something is wrong" case.
How convenient, dbaron is a Test Harness peer. :-) [I should note I haven't run this yet, but it seems like an obvious enough change.]
Assignee: nobody → dolske
Attachment #340420 - Flags: review?(dbaron)
Added another check for one of the columns that might be negative, and tested that it works with and without negative values in the output.
Comment on attachment 340472 [details] [diff] [review] Patch v.2 r=dbaron, although you might want to run this by whoever owns runtests.py.in.
Attachment #340472 - Flags: review?(dbaron) → review+
Attachment #340472 - Flags: review?(ted.mielczarek)
Attachment #340472 - Flags: review?(ted.mielczarek) → review+
Pushed changeset 5fabcd7363bf.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Component: Testing → Mochitest
Product: Core → Testing
QA Contact: testing → mochitest
Target Milestone: mozilla1.9.1b2 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.