456894 - runtests.py can't handle negative leaks

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Justin Dolske [:Dolske]]

While investigating some failures, I found some cases where runtests.py complains "missing output line for total leaks!", when it's clearly in the output.

Example from http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1221925353.1221933011.32720.gz&fulltext=1#err46

Scroll up and you'll find:

   0 TOTAL                                          -4    63920 -1005666652 ....

Looks like the problem is the regex runtests.py uses to find the "TOTAL" line. It's not expecting negative numbers. dbaron says this can happen when bogus addref/release patterns confuse tracerefcount.

The script should catch these, and handle as a "omgwtf something is wrong" case.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

How convenient, dbaron is a Test Harness peer. :-)

[I should note I haven't run this yet, but it seems like an obvious enough change.]

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Added another check for one of the columns that might be negative, and tested that it works with and without negative values in the output.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 340472 [details] [diff] [review]
Patch v.2

r=dbaron, although you might want to run this by whoever owns runtests.py.in.

Comment 4

[Justin Dolske [:Dolske]]

Pushed changeset 5fabcd7363bf.