456922 - Now that Bugzilla::Field::Choice is complete, clean up editvalues.cgi and error messages

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Now that we have a fully-functional Bugzilla::Field::Choice object, we should use it everywhere in editvalues.cgi and pass it correctly to error messages as an object.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This is really an interesting kind of full-circle job for me. :-) editvalues.cgi was the first major feature I ever actually added to Bugzilla. It's really interesting to see how much my understanding (and code style) has evolved over all these years of working with Bugzilla.

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 340288 [details] [diff] [review]
v1

r=bbaetz

Much cleaner, and deleting ~120 lines from edit* is always good

Comment 3

[Max Kanat-Alexander]

Putting in the approval queue for when all blockers get r+.

Comment 4

[Max Kanat-Alexander]

Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.35; previous revision: 1.34
done
Checking in Bugzilla/Field/Choice.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field/Choice.pm,v  <--  Choice.pm
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/fieldvalues/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/admin/fieldvalues/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/admin/fieldvalues/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/admin/fieldvalues/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/footer.html.tmpl,v  <--  footer.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/admin/fieldvalues/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v  <--  messages.html.tmpl
new revision: 1.78; previous revision: 1.77
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.262; previous revision: 1.261
done