Closed
Bug 456922
Opened 16 years ago
Closed 16 years ago
Now that Bugzilla::Field::Choice is complete, clean up editvalues.cgi and error messages
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
30.61 KB,
patch
|
bbaetz
:
review+
|
Details | Diff | Splinter Review |
Now that we have a fully-functional Bugzilla::Field::Choice object, we should use it everywhere in editvalues.cgi and pass it correctly to error messages as an object.
Assignee | ||
Comment 1•16 years ago
|
||
This is really an interesting kind of full-circle job for me. :-) editvalues.cgi was the first major feature I ever actually added to Bugzilla. It's really interesting to see how much my understanding (and code style) has evolved over all these years of working with Bugzilla.
Comment 2•16 years ago
|
||
Comment on attachment 340288 [details] [diff] [review]
v1
r=bbaetz
Much cleaner, and deleting ~120 lines from edit* is always good
Attachment #340288 -
Flags: review?(bbaetz) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Putting in the approval queue for when all blockers get r+.
Flags: approval?
Assignee | ||
Updated•16 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 4•16 years ago
|
||
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v <-- editvalues.cgi
new revision: 1.35; previous revision: 1.34
done
Checking in Bugzilla/Field/Choice.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field/Choice.pm,v <-- Choice.pm
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/fieldvalues/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v <-- confirm-delete.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/admin/fieldvalues/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl,v <-- create.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/admin/fieldvalues/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl,v <-- edit.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/admin/fieldvalues/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/footer.html.tmpl,v <-- footer.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/admin/fieldvalues/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/list.html.tmpl,v <-- list.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl
new revision: 1.78; previous revision: 1.77
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl
new revision: 1.262; previous revision: 1.261
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
![]() |
||
Updated•16 years ago
|
Target Milestone: Bugzilla 4.0 → Bugzilla 3.4
You need to log in
before you can comment on or make changes to this bug.
Description
•