456959 - Options->Advanced->Encryptation->Revocation Lists can open multiple crlManager.xul windows

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Philip Chee]

Attachment: Fix window type in showCRLs()

Steps to reproduce:
1. Options->Advanced->Encryption
2. Click on the [Revocation Lists] button.
3. Click on the [Revocation Lists] button again.
4. Click on the [Revocation Lists] button and again.

Actual Results:
Multiple [Manage CRLs] windows open.

Expected Results:
Once one window is opened, additional clicks should just focus on the existing window.

<http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/preferences/advanced.js#518>
  showCRLs: function ()
  {
    document.documentElement.openWindow("Mozilla:CRLManager", 
                                        "chrome://pippki/content/crlManager.xul",
                                        "", null);
  },

Reason: crlManager.xul never had a window type until I fixed it in Bug 445015 (see http://hg.mozilla.org/mozilla-central/rev/8fcf92cfd811). For consistency with the rest of pippki I used an all lower cased window type.

This patch makes Firefox use the right window type. Note this never worked ,so technically this isn't a regression.

Comment 1

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/93210b4517d8

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 340313 [details] [diff] [review]
Fix window type in showCRLs()

New branch policy argues against easy "nice to haves" unfortunately -- there's hundreds of bugs like this and QA can't keep up when we take them all. FF3.1 will be fixed.