Closed
Bug 457050
Opened 16 years ago
Closed 16 years ago
[FIX]Reloading page with javascript: URI asserts in loadgroup code
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
2.11 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
1.19 KB,
patch
|
Details | Diff | Splinter Review |
In particular, we end up adding the JSChannel as background, then removing it as not background, and send the mForegroundCount counter negative (or rather very big). Patch to fix attached. Not sure how to best test this automatically.
Attachment #340381 -
Flags: superreview?(cbiesinger)
Attachment #340381 -
Flags: review?(cbiesinger)
Comment 1•16 years ago
|
||
When run using "-reftest", this triggers: ###!!! ASSERTION: ForegroundCount messed up: 'mForegroundCount > 0', file /Users/jruderman/central/netwerk/base/src/nsLoadGroup.cpp, line 679 and a bunch of: ###!!! ASSERTION: Foreground URLs are active.: 'mForegroundCount == 0', file /Users/jruderman/central/netwerk/base/src/nsLoadGroup.cpp, line 355
Assignee | ||
Comment 2•16 years ago
|
||
Sweet. Those are exactly what I was seeing.
Updated•16 years ago
|
Comment 3•16 years ago
|
||
Comment on attachment 340381 [details] [diff] [review] Fix + PRBool loadGroupIsBackround = PR_FALSE; missing g in the variable name but... why isn't it enough to check mActualLoadFlags & LOAD_BACKGROUND? why do you have to check the load group?
Assignee | ||
Comment 4•16 years ago
|
||
Because the loadgroup as a whole may be LOAD_BACKGROUND, and that flag might be getting set on us via MergeLoadGlags. That's where the SetLoadFlags call that confuses us comes from in the testcase.
Updated•16 years ago
|
Attachment #340381 -
Flags: superreview?(cbiesinger)
Attachment #340381 -
Flags: superreview+
Attachment #340381 -
Flags: review?(cbiesinger)
Attachment #340381 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
QA Contact: content
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•