Created attachment 340386 [details] [diff] [review] patch v.1 simply convert the incoming string to wide, and use MessageBoxW.
Attachment #340386 - Flags: review?(benjamin)
Comment on attachment 340386 [details] [diff] [review] patch v.1 coulda sworn there was a simpler macro that could do the same thing, but r=me
Attachment #340386 - Flags: review?(benjamin) → review+
Why didn't we just change Output over to take a wide message? Surely cheaper than converting the darn string.
yeah, it is a time/space tradeoff. I didn't want to double the size of the strings for a function that is rarely called.
well, maybe with the buffer that i need for the conversion, it doesn't matter. Things I need to make this change: vfwprintf is this portable? windows replaces for PR_vsmprintf for wide strings. bsmedberg, decide plz.
We can't effectively make Output use a wide string because the other implementations require a narrow string. The incoming charset isn't documented, but it's probably ASCII (and we should probably document that). You're welcome to use vfwprintf in windows-only code, but it's certainly not portable.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.