457104 - nsTextServicesDocument::FirstSelectedBlock dead?

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(dormant account)]

Roc or someone else:
It seems that a bunch of methods in editor/ are never called. The are the largest out uncalled methods in Moz. I'd like to start with FirstSelectedBlock as it's the biggest, is it ok to remove it?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Peterv is the right person to ask.

Comment 2

[(dormant account)]

Peterv, 
By a bunch I mean atleast the following:
nsTextServicesDocument::FirstSelectedBlock
nsTextServicesDocument::GetDOMRangeFor
nsTextServicesDocument::InitWithDocument
nsTextServicesDocument::LastBlock
nsTextServicesDocument::GetDocument
nsTextServicesDocument::GetExtent
nsTextServicesDocument::CanEdit
nsTextServicesDocument::SetDisplayStyle

Is there any reason to keep these?

Comment 3

[(dormant account)]

also 
nsHTMLEditor::GetParentBlockTags is dead to me
nsHTMLEditor::GetNextElementByTagName is dead to me
nsHTMLEditor::GetFirstCellInRow is dead to me
nsHTMLEditor::GetNextCellInRow is dead to me
nsHTMLEditor::IsSubordinateBlock is dead to me
nsHTMLEditor::GetHighlightColor is dead to me
nsHTMLEditor::HasSameBlockNodeParent is dead to me
nsHTMLEditor::ResetTextSelectionForRange is dead to me
nsHTMLEditor::GetAbsoluteOffsetsForPoints is dead to me
nsHTMLEditor::AddCSSStyleSheet is dead to me
are high on the dead code size list

Comment 4

[Peter Van der Beken [:peterv]]

I'm fine with removing these, but I haven't checked personally whether they're still used or not.

Comment 5

[Fred Jendrzejewski]

Attachment: removed the functions

I took a look in mxr, removed everything that is dead for me and it builds and works fine for me.

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 349940 [details] [diff] [review]
removed the functions

Pleae also remove InitWithDocument from the comment in nsITextServicesDocument.h.

Comment 7

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/bbb30d93a82f