Closed Bug 457129 Opened 15 years ago Closed 15 years ago

TM: cmp number-check logic wrong on AMD64

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(2 files)

proposed fix
700 bytes, patch
gal
: review-
Details | Diff | Splinter Review
proposed fix v2
898 bytes, patch
gal
: review+
Details | Diff | Splinter Review
Attached patch proposed fix — — Splinter Review 
can't use isQuad() since it could be a pointer
Attachment #340468 - Flags: review?(gal)
Comment on attachment 340468 [details] [diff] [review]
proposed fix

No, you have to check isNumber() && isQuad to safely tell its a float (or not a float in this case).
Attachment #340468 - Flags: review?(gal) → review-
Attached patch proposed fix v2 — — Splinter Review 
Assignee: general → danderson
Status: NEW → ASSIGNED

        Attachment #340974 -
        Flags: review?(gal)

    
    

    
  
Comment on attachment 340974 [details] [diff] [review]
proposed fix v2

Why not !(isNumber(l) && isQuad()) ? Isn't that what logically makes sense?

    
  

        Attachment #340974 -
        Flags: review?(gal) → review+

    
    

    
  
Pushed fix as changset http://hg.mozilla.org/tracemonkey/rev/6ceb773fac22
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-

          You need to log in
          before you can comment on or make changes to this bug.