Closed Bug 457129 Opened 14 years ago Closed 14 years ago

TM: cmp number-check logic wrong on AMD64

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(2 files)

Attached patch proposed fixSplinter Review
can't use isQuad() since it could be a pointer
Attachment #340468 - Flags: review?(gal)
Comment on attachment 340468 [details] [diff] [review]
proposed fix

No, you have to check isNumber() && isQuad to safely tell its a float (or not a float in this case).
Attachment #340468 - Flags: review?(gal) → review-
Attached patch proposed fix v2Splinter Review
Assignee: general → danderson
Status: NEW → ASSIGNED
Attachment #340974 - Flags: review?(gal)
Comment on attachment 340974 [details] [diff] [review]
proposed fix v2

Why not !(isNumber(l) && isQuad()) ? Isn't that what logically makes sense?
Attachment #340974 - Flags: review?(gal) → review+
Pushed fix as changset http://hg.mozilla.org/tracemonkey/rev/6ceb773fac22
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.