457160 - Customize toolbar only showing some of the icons

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[TimoT]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080924164518 Firefox/3.1b1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080924164518 Firefox/3.1b1pre

Bug 264488 seems to have broken the customize toolbar. For me only Separator, Flexible Space and Space icons show up. If I drag a button into the customize toolbar the icon disappears immediately.

Reproducible: Always

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

confirmed using Minefield/3.1b1pre ID:20080925143834 on WinXP.
range: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-09-25+03%3A00%3A00&enddate=2008-09-25+14%3A38%3A00

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

better range:
works: Minefield/3.1b1pre ID: 20080925110153 (http://hg.mozilla.org/mozilla-central/rev/7b75a1f34434)
fails: Minefield/3.1b1pre ID: 20080925124346 (http://hg.mozilla.org/mozilla-central/rev/92cc665e9b84)

=> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b75a1f34434&tochange=92cc665e9b84

=> CCing Simon, Gavin.

Comment 3

[Simon Bünzli]

Attachment: fix

Oops. We surely want all toolbar related stuff to be visible as well...

Comment 4

[Justin Wood (:Callek)]

$ hg outgoing -v && hg push
running "ssh hg.mozilla.org "hg -R mozilla-central/ serve --stdio""
comparing with ssh://hg.mozilla.org/mozilla-central/
searching for changes
changeset:   19818:23659e89954c
tag:         tip
user:        Simon Bünzil <[e-mail]>
date:        Sat Sep 27 12:12:04 2008 -0400
files:       browser/base/content/browser.js
description:
Bug 457160, Customize toolbar only showing some of the icons
r=gavin


pushing to ssh://hg.mozilla.org/mozilla-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed with build:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080927125325 Minefield/3.1b1pre Firefox/3.0 ID:20080927125325