Closed
Bug 457208
Opened 16 years ago
Closed 16 years ago
Useless border rules for input[type=image] in quirk.css
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: crazy-daniel, Assigned: crazy-daniel)
Details
Attachments
(1 file)
|
2.71 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
quirk.css contains rules that give a blue border to image type input elements. However, these rules are reset by the styles in forms.css anyway; they can be removed. Besides, not creating a blue border is what everyone else does. The patch also contains some whitespace cleanup.
Attachment #340556 -
Flags: superreview?(dbaron)
Attachment #340556 -
Flags: review?(dbaron)
Comment on attachment 340556 [details] [diff] [review] quirk.css cleanup [Checkin: Comment 2] r+sr=dbaron In the future, please do whitespace cleanup in separate patches (unless the whitespace cleanup is a small fraction of the patch; here it's about 80%)
Attachment #340556 -
Flags: superreview?(dbaron)
Attachment #340556 -
Flags: superreview+
Attachment #340556 -
Flags: review?(dbaron)
Attachment #340556 -
Flags: review+
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
Comment on attachment 340556 [details] [diff] [review] quirk.css cleanup [Checkin: Comment 2] http://hg.mozilla.org/mozilla-central/rev/35e15f6957dc
Attachment #340556 -
Attachment description: quirk.css cleanup → quirk.css cleanup
[Checkin: Comment 2]
|
|
||
Updated•16 years ago
|
Assignee: nobody → crazy-daniel
Severity: normal → trivial
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•