Bug 457262 (deadcode)

[meta] Delete dead code

RESOLVED FIXED

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
9 years ago
2 years ago

People

(Reporter: (dormant account), Unassigned)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 obsolete attachments)

(Reporter)

Description

9 years ago
This is a bug to track dead code deletion as facilitated by static analysis.
(Reporter)

Updated

9 years ago
Depends on: 457102, 457104, 457119, 457125
(Reporter)

Updated

9 years ago
Depends on: 457302
(Reporter)

Updated

9 years ago
Depends on: 457303
(Reporter)

Updated

9 years ago
Depends on: 457313
(Reporter)

Updated

9 years ago
Depends on: 457323
(Reporter)

Updated

9 years ago
Depends on: 457949
(Reporter)

Updated

9 years ago
Depends on: 457959
(Reporter)

Updated

9 years ago
Depends on: 457965
(Reporter)

Updated

9 years ago
Depends on: 457969
Created attachment 341281 [details]
possibly constant expressions
so i built a build with -Wall -W and there are 51 lines with possibly constant expressions - see attachment.

the most drastic:
1601:../../../dist/include/lcms/lcms.h:1436: warning: comparison of unsigned expression < 0 is always false

LCMS_INLINE void* _cmsMalloc(size_t size)
{
    if (size > ((size_t) 1024*1024*500)) return NULL;  // Never allow over 500Mb
    if (size < 0) return NULL;
Created attachment 341285 [details]
13 possibly unused vars

13 possibly unused vars
are the 64 gcc warnings worth a new bug - probably the fix will be just deleting lines?
(Reporter)

Comment 5

9 years ago
yeah, please file a new bug and make it block this one.
(Reporter)

Updated

9 years ago
Depends on: 458421
Depends on: 458491
gcc warnings are Bug 458491
(Reporter)

Updated

9 years ago
Depends on: 458969
(Reporter)

Updated

9 years ago
Depends on: 458983
(Reporter)

Updated

9 years ago
Depends on: 458984
(Reporter)

Updated

9 years ago
Depends on: 459306
(Reporter)

Updated

9 years ago
Depends on: 471087
Depends on: 514986
Depends on: 514987
Depends on: 514988
Depends on: 514989
Depends on: 514990

Updated

8 years ago
Depends on: 543255

Updated

8 years ago
Depends on: 555851

Updated

8 years ago
Depends on: 556446

Comment 7

8 years ago
Added to the list:
Bug 537223 - Cleanup of gfxColor.h
Bug 230675 - 'decom' of nsICacheVisitor.idl: saves 10% / 150K
Bug 405407 - Merge nsDiskCacheStreamIO and nsDiskCacheStreamOutput
Bug 386937 - ConvertPixel doesn't work as nsColor and gfx_color are not compatible...
Depends on: 537223, 230675, 405407, 386937

Updated

7 years ago
Depends on: 559489
Depends on: 597293
Depends on: 679352

Updated

6 years ago
Depends on: 705427

Updated

6 years ago
Depends on: 705428

Updated

6 years ago
Depends on: 705429

Updated

6 years ago
Depends on: 705430

Updated

6 years ago
Depends on: 705432

Updated

6 years ago
Depends on: 705433

Updated

6 years ago
Depends on: 705434

Updated

6 years ago
Depends on: 705435

Updated

6 years ago
Depends on: 705436

Updated

6 years ago
Depends on: 705437

Updated

6 years ago
Depends on: 705438

Updated

6 years ago
Depends on: 705439
(Reporter)

Comment 8

6 years ago
Ms2get good stuff, how are you finding these?
See the URL field :)
Blocks: 706113

Updated

6 years ago
No longer blocks: 706113
Depends on: 706113

Updated

6 years ago
Blocks: 709193

Updated

6 years ago
Depends on: 709511

Updated

6 years ago
Depends on: 709512

Updated

6 years ago
Depends on: 709513

Updated

6 years ago
Depends on: 709516

Updated

6 years ago
Depends on: 709518

Updated

6 years ago
Depends on: 709519

Updated

6 years ago
Depends on: 709522

Updated

6 years ago
Depends on: 709523

Updated

6 years ago
Depends on: 709524

Updated

6 years ago
Depends on: 709525

Updated

6 years ago
Depends on: 709526

Updated

6 years ago
Depends on: 709528

Updated

6 years ago
Depends on: 709533

Updated

6 years ago
Depends on: 695648

Comment 10

6 years ago
Comment on attachment 341281 [details]
possibly constant expressions

Attachment moved to bug 458491.
Attachment #341281 - Attachment is obsolete: true

Comment 11

6 years ago
Comment on attachment 341285 [details]
13 possibly unused vars

Attachment moved to bug 458491.
Attachment #341285 - Attachment is obsolete: true

Updated

6 years ago
Depends on: 709709, 709562

Comment 12

6 years ago
What modules does this bug actually cover?
(Reporter)

Comment 13

6 years ago
(In reply to :aceman from comment #12)
> What modules does this bug actually cover?

C/C++ code that gets compiled in firefox

Comment 14

6 years ago
Thanks, so if only Firefox (and not e.g. Thunderbird code above Gecko and Toolkit core), please write it into the summary.

Updated

6 years ago
Depends on: 711826

Updated

6 years ago
Depends on: 713553

Updated

6 years ago
Depends on: 713554
Depends on: 719407

Updated

6 years ago
Depends on: 711790

Updated

6 years ago
Alias: deadcode

Updated

6 years ago
Depends on: 736619

Updated

6 years ago
Depends on: 736746
Depends on: 738705

Updated

6 years ago
Depends on: 738957

Updated

6 years ago
Depends on: 739124

Updated

6 years ago
Depends on: 740945

Updated

5 years ago
Blocks: 750661
Depends on: 750859

Updated

5 years ago
Depends on: 751035

Updated

5 years ago
Depends on: 751280

Updated

5 years ago
Depends on: 751416

Updated

5 years ago
Depends on: 854231

Updated

4 years ago
Depends on: 880196

Updated

4 years ago
Depends on: 883504

Updated

4 years ago
Depends on: 883537

Updated

4 years ago
Depends on: 888366

Updated

4 years ago
Depends on: 888579

Updated

4 years ago
Depends on: 900978

Updated

4 years ago
Depends on: 902607

Updated

4 years ago
Depends on: 909028

Updated

4 years ago
Depends on: 913953

Updated

4 years ago
Depends on: 921882

Updated

4 years ago
Depends on: 921880

Updated

4 years ago
Depends on: 923250
Depends on: 926580

Updated

4 years ago
Depends on: 973950

Updated

4 years ago
Depends on: 973476

Updated

3 years ago
Depends on: 995780

Updated

3 years ago
Depends on: 1017752

Updated

3 years ago
Depends on: 1028064
Is this bug still needed?
Nicolas, I don't think it is the case. For clang static analyzer, bug 712350 should be used
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Depends on: 1046139

Updated

3 years ago
Depends on: 1086510

Updated

2 years ago
Depends on: 1147572
Depends on: 1147967
Depends on: 1152052
Depends on: 1152079

Updated

2 years ago
Depends on: 1184630
Depends on: 1230379
You need to log in before you can comment on or make changes to this bug.