Closed
Bug 457262
(deadcode)
Opened 15 years ago
Closed 9 years ago
[meta] Delete dead code
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Unassigned)
References
(Depends on 1 open bug, )
Details
(Keywords: meta)
Attachments
(2 obsolete files)
This is a bug to track dead code deletion as facilitated by static analysis.
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
so i built a build with -Wall -W and there are 51 lines with possibly constant expressions - see attachment. the most drastic: 1601:../../../dist/include/lcms/lcms.h:1436: warning: comparison of unsigned expression < 0 is always false LCMS_INLINE void* _cmsMalloc(size_t size) { if (size > ((size_t) 1024*1024*500)) return NULL; // Never allow over 500Mb if (size < 0) return NULL;
Comment 3•15 years ago
|
||
13 possibly unused vars
Comment 4•15 years ago
|
||
are the 64 gcc warnings worth a new bug - probably the fix will be just deleting lines?
Reporter | ||
Comment 5•15 years ago
|
||
yeah, please file a new bug and make it block this one.
Comment 6•15 years ago
|
||
gcc warnings are Bug 458491
Comment 7•14 years ago
|
||
Added to the list: Bug 537223 - Cleanup of gfxColor.h Bug 230675 - 'decom' of nsICacheVisitor.idl: saves 10% / 150K Bug 405407 - Merge nsDiskCacheStreamIO and nsDiskCacheStreamOutput Bug 386937 - ConvertPixel doesn't work as nsColor and gfx_color are not compatible...
Reporter | ||
Comment 8•12 years ago
|
||
Ms2get good stuff, how are you finding these?
Comment 9•12 years ago
|
||
See the URL field :)
Updated•12 years ago
|
![]() |
||
Comment 10•12 years ago
|
||
Comment on attachment 341281 [details] possibly constant expressions Attachment moved to bug 458491.
Attachment #341281 -
Attachment is obsolete: true
![]() |
||
Comment 11•12 years ago
|
||
Comment on attachment 341285 [details] 13 possibly unused vars Attachment moved to bug 458491.
Attachment #341285 -
Attachment is obsolete: true
![]() |
||
Updated•12 years ago
|
![]() |
||
Comment 12•12 years ago
|
||
What modules does this bug actually cover?
Reporter | ||
Comment 13•12 years ago
|
||
(In reply to :aceman from comment #12) > What modules does this bug actually cover? C/C++ code that gets compiled in firefox
![]() |
||
Comment 14•12 years ago
|
||
Thanks, so if only Firefox (and not e.g. Thunderbird code above Gecko and Toolkit core), please write it into the summary.
Updated•12 years ago
|
Alias: deadcode
![]() |
||
Comment 15•9 years ago
|
||
Is this bug still needed?
Comment 16•9 years ago
|
||
Nicolas, I don't think it is the case. For clang static analyzer, bug 712350 should be used
![]() |
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•1 year ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•