457262 - (deadcode) [meta] Delete dead code

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[(dormant account)]

This is a bug to track dead code deletion as facilitated by static analysis.

Comment 1

[georgi - hopefully not receiving bugspam]

Attachment: possibly constant expressions

Comment 2

[georgi - hopefully not receiving bugspam]

so i built a build with -Wall -W and there are 51 lines with possibly constant expressions - see attachment.

the most drastic:
1601:../../../dist/include/lcms/lcms.h:1436: warning: comparison of unsigned expression < 0 is always false

LCMS_INLINE void* _cmsMalloc(size_t size)
{
    if (size > ((size_t) 1024*1024*500)) return NULL;  // Never allow over 500Mb
    if (size < 0) return NULL;

Comment 3

[georgi - hopefully not receiving bugspam]

Attachment: 13 possibly unused vars

13 possibly unused vars

Comment 4

[georgi - hopefully not receiving bugspam]

are the 64 gcc warnings worth a new bug - probably the fix will be just deleting lines?

Comment 5

[(dormant account)]

yeah, please file a new bug and make it block this one.

Comment 6

[georgi - hopefully not receiving bugspam]

gcc warnings are Bug 458491

Comment 7

[Alfred Kayser]

Added to the list:
Bug 537223 - Cleanup of gfxColor.h
Bug 230675 - 'decom' of nsICacheVisitor.idl: saves 10% / 150K
Bug 405407 - Merge nsDiskCacheStreamIO and nsDiskCacheStreamOutput
Bug 386937 - ConvertPixel doesn't work as nsColor and gfx_color are not compatible...

Comment 8

[(dormant account)]

Ms2get good stuff, how are you finding these?

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

See the URL field :)

Comment 10

[:aceman]

Comment on attachment 341281 [details]
possibly constant expressions

Attachment moved to bug 458491.

Comment 11

[:aceman]

Comment on attachment 341285 [details]
13 possibly unused vars

Attachment moved to bug 458491.

Comment 12

[:aceman]

What modules does this bug actually cover?

Comment 13

[(dormant account)]

(In reply to :aceman from comment #12)
> What modules does this bug actually cover?

C/C++ code that gets compiled in firefox

Comment 14

[:aceman]

Thanks, so if only Firefox (and not e.g. Thunderbird code above Gecko and Toolkit core), please write it into the summary.

Comment 15

[Nicholas Nethercote [inactive]]

Is this bug still needed?

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Nicolas, I don't think it is the case. For clang static analyzer, bug 712350 should be used