Closed Bug 457262 (deadcode) Opened 15 years ago Closed 9 years ago

[meta] Delete dead code

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: taras.mozilla, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Keywords: meta)

Attachments

(2 obsolete files) 

This is a bug to track dead code deletion as facilitated by static analysis.
Depends on: 457102, 457104, 457119, 457125
Depends on: 457302
Depends on: 457303
Depends on: 457313
Depends on: 457323
Depends on: 457949
Depends on: 457959
Depends on: 457965
Depends on: 457969
so i built a build with -Wall -W and there are 51 lines with possibly constant expressions - see attachment.

the most drastic:
1601:../../../dist/include/lcms/lcms.h:1436: warning: comparison of unsigned expression < 0 is always false

LCMS_INLINE void* _cmsMalloc(size_t size)
{
    if (size > ((size_t) 1024*1024*500)) return NULL;  // Never allow over 500Mb
    if (size < 0) return NULL;
Attached file 13 possibly unused vars (obsolete) — 
13 possibly unused vars
are the 64 gcc warnings worth a new bug - probably the fix will be just deleting lines?
yeah, please file a new bug and make it block this one.
Depends on: 458421
Depends on: 458969
Depends on: 458983
Depends on: 458984
Depends on: 459306
Depends on: 471087
Depends on: 514986
Depends on: 514987
Depends on: 514988
Depends on: 514989
Depends on: 514990
Depends on: 543255
Depends on: 555851
Depends on: 556446
Added to the list:
Bug 537223 - Cleanup of gfxColor.h
Bug 230675 - 'decom' of nsICacheVisitor.idl: saves 10% / 150K
Bug 405407 - Merge nsDiskCacheStreamIO and nsDiskCacheStreamOutput
Bug 386937 - ConvertPixel doesn't work as nsColor and gfx_color are not compatible...
Depends on: 537223, 230675, 405407, 386937
Depends on: 559489
Depends on: 597293
Depends on: 679352
Depends on: 705427
Depends on: 705428
Depends on: 705429
Depends on: 705430
Depends on: 705432
Depends on: 705433
Depends on: 705434
Depends on: 705435
Depends on: 705436
Depends on: 705437
Depends on: 705438
Depends on: 705439
Ms2get good stuff, how are you finding these?
See the URL field :)
No longer blocks: 706113
Depends on: 706113
Blocks: 709193
Depends on: 709511
Depends on: 709512
Depends on: 709513
Depends on: 709516
Depends on: 709518
Depends on: 709519
Depends on: 709522
Depends on: 709523
Depends on: 709524
Depends on: 709525
Depends on: 709526
Depends on: 709528
Depends on: 709533
Depends on: 695648
Comment on attachment 341281 [details]
possibly constant expressions

Attachment moved to bug 458491.
Attachment #341281 - Attachment is obsolete: true
Comment on attachment 341285 [details]
13 possibly unused vars

Attachment moved to bug 458491.
Attachment #341285 - Attachment is obsolete: true
Depends on: 709709, 709562
What modules does this bug actually cover?
(In reply to :aceman from comment #12)
> What modules does this bug actually cover?

C/C++ code that gets compiled in firefox
Thanks, so if only Firefox (and not e.g. Thunderbird code above Gecko and Toolkit core), please write it into the summary.
Depends on: 711826
Depends on: 713553
Depends on: 713554
Depends on: 719407
Depends on: 711790
Alias: deadcode
Depends on: 736619
Depends on: 736746
Depends on: 738705
Depends on: 738957
Depends on: 739124
Depends on: 740945
Blocks: 750661
Depends on: 750859
Depends on: 751035
Depends on: 751280
Depends on: 751416
Depends on: 854231
Depends on: 880196
Depends on: 883504
Depends on: 883537
Depends on: 888366
Depends on: 888579
Depends on: 900978
Depends on: 902607
Depends on: 909028
Depends on: 913953
Depends on: 921882
Depends on: 921880
Depends on: 923250
Depends on: 926580
Depends on: 973950
Depends on: 973476
Depends on: 995780
Depends on: 1017752
Depends on: 1028064
Is this bug still needed?
Nicolas, I don't think it is the case. For clang static analyzer, bug 712350 should be used
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 1046139
Depends on: 1086510
Depends on: 1147572
Depends on: 1147967
Depends on: 1152052
Depends on: 1152079
Depends on: 1184630
Depends on: 1230379
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.