Closed
Bug 457299
Opened 16 years ago
Closed 16 years ago
caps changes contexts on a thread without suspending the first one's request
Categories
(Core :: Security: CAPS, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file)
|
2.28 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
In particular, InitPolicies is called from under CheckPropertyAccessImpl which is called under a request but it uses the safe context without suspending the current context.
|
Assignee | |
Comment 1•16 years ago
|
||
This does fixes it by using the context stack to do the suspending for me.
Attachment #340627 -
Flags: superreview?(bzbarsky)
Attachment #340627 -
Flags: review?(bzbarsky)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 340627 [details] [diff] [review] Proposed fix Should we worry about Push() failing? Either way, I guess....
Attachment #340627 -
Flags: superreview?(bzbarsky)
Attachment #340627 -
Flags: superreview+
Attachment #340627 -
Flags: review?(bzbarsky)
Attachment #340627 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
I'll add a check to ensure we don't pop if the push fails.
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed as http://hg.mozilla.org/mozilla-central/rev/8e8a50453722
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•