Created attachment 340629 [details] [diff] [review] Patch to fix a weird sentence for product update download progress message The lack of localization notes at  together with the difficulty to test the product update download dialog and my own fault by not properly seeing how the different strings chained together to form the final message, has caused a weird sentence for the download progress message in es-ES. It says: 1.3 MB de 2.0 MB en 125 KB/seg; 2:18 quedan when it should say 1.3 MB de 2.0 MB a 125 KB/seg; quedan 2:18  http://mxr.mozilla.org/firefox/source/toolkit/locales/en-US/chrome/mozapps/update/updates.properties The affected keys in updates.properties are rateFormat and timeFormat. I'm fixing this in Mercurial for Gecko 1.9.1, but I also request approval to fix it for Gecko 1.9.0 (Firefox 3.0.x).
Attachment #340629 - Flags: approval22.214.171.124?
Comment on attachment 340629 [details] [diff] [review] Patch to fix a weird sentence for product update download progress message a=me. Please land this with a check-in comment referencing this bug and my approval. Use the fixed126.96.36.199 and verified188.8.131.52 keywords to track landing and testing.
Attachment #340629 - Flags: approval184.108.40.206? → approval220.127.116.11+
$ cvs commit -m "Fix for bug 457301 - Download progress in product update dialog is badly expressed, approved by Axel, made by Ricardo" cvs commit: Examining . Checking in updates.properties; /l10n/l10n/es-ES/toolkit/chrome/mozapps/update/updates.properties,v <-- updates.properties new revision: 1.11; previous revision: 1.10 done Patch committed. Thank you, Axel.
I've downloaded a 3.0.4 nightly and updates.properties has the changes applied. Besides, I've manually replaced that file in my Firefox 3.0.1 installation, and asked to update. The message shows now OK, so I'm marking this bug Verified. I've applied the fix also in Mercurial repository for Gecko 1.9.1.
Keywords: fixed18.104.22.168 → verified22.214.171.124
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.