Closed
Bug 457310
Opened 16 years ago
Closed 16 years ago
xpcwrappedjsclass causes assertions due to exception ordering
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file, 1 obsolete file)
|
1.43 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
In particular, in nsXPCWrappedJSClass::CheckForException, we can run code before we clear the exception on our context. This hits a JS assertion if that code attempts to use a 'return' statement or calls a native function.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #340638 -
Flags: superreview?(jst)
Attachment #340638 -
Flags: review?(jst)
|
|
Assignee | |
Comment 2•16 years ago
|
||
bent pointed out that the previous patch interacted badly with bug 455436. This is a different offering that doesn't touch xpcwrappedjsclass at all, preferring to be closer to the source of the problem.
Attachment #340638 -
Attachment is obsolete: true
Attachment #340647 -
Flags: superreview?(jst)
Attachment #340647 -
Flags: review?(jst)
Attachment #340638 -
Flags: superreview?(jst)
Attachment #340638 -
Flags: review?(jst)
|
||
Updated•16 years ago
|
Attachment #340647 -
Flags: superreview?(jst)
Attachment #340647 -
Flags: superreview+
Attachment #340647 -
Flags: review?(jst)
Attachment #340647 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1d3bb5a6ee34
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•