45732 - _linux.cfg in nsprpub tree is wrong for powerpc linux

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Kevin B. Hendricks]

_linux.cfg in nsprpub tree is wrong for powerpc linux.  Both int64 and doubles
on powerpc linux are aligned to 8 and not 4 as that file states.  Furthermore
the defines HAVE_ALIGNED_LONGLONGS and HAVE_ALIGNED_DOUBLES should be properly
set.

As is, the latest oji plugin code built from the latest Blackdown JDK 1.3 source
tree will not work on powerpc based linux (problems with alignment of unions in
the pipe code).  Hopefully, this change will help fix that problem.

Thanks,

Kevin B. Hendricks
Blackdown Organization for Java Linux
[e-mail]

Comment 1

[Wan-Teh Chang]

I did an LXR search for HAVE_ALIGNED_LONGLONGS
and HAVE_ALIGNED_DOUBLES and found the following
comments in
mozilla/sun-java/stubs/include/jri_md.h
that explain the meaning of these two and other
related macros defined in NSPR's _xxx.cfg files:

-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=
On UNIX though you probably care about a couple of other symbols though:
 IS_LITTLE_ENDIAN must be defined for little-endian systems
 HAVE_LONG_LONG must be defined on systems that have 'long long' integers
 HAVE_ALIGNED_LONGLONGS must be defined if long-longs must be 8 byte aligned
 HAVE_ALIGNED_DOUBLES must be defined if doubles must be 8 byte aligned
 IS_64 must be defined on 64-bit machines (like Dec Alpha)
-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=-*=

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 3

[Wan-Teh Chang]

*** Bug 45746 has been marked as a duplicate of this bug. ***

Comment 4

[Wan-Teh Chang]

I checked in the patch on the main trunk.

/cvsroot/mozilla/nsprpub/pr/include/md/_linux.cfg, revision 3.12

Note that Mozilla is pulling mozilla/nsprpub from a branch tag
(NSPRPUB_CLIENT_BRANCH).

Comment 5

[Wan-Teh Chang]

I checked in the patch on the following branches.

NSPRPUB_RELEASE_4_0_BRANCH.
/cvsroot/mozilla/nsprpub/pr/include/md/_linux.cfg, revision 3.7.14.2

NSPRPUB_CLIENT_BRANCH.
/cvsroot/mozilla/nsprpub/pr/include/md/_linux.cfg, revision 3.8.2.1