If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

ISimpleDOMNode navigation methods creates nsAccessNodeWrap everytime

RESOLVED WONTFIX

Status

()

Core
Disability Access APIs
--
major
RESOLVED WONTFIX
9 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

unspecified
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

15.34 KB, patch
Aaron Leventhal
: review+
MarcoZ
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
For example, nsIAccessNode firtsChildNode methods creates nsAccessNode and cache it so that firstChildNode doesn't look to the cache before it creates new object. It leads to problems if AT has own accessibles cache. When they navigate by ISimpleDOMnode navigation methods then they makes his cache out of date.

Thanks Matt Campbell for the issue pointing.

Comment 1

9 years ago
This seems like a huge bug to me.
Severity: normal → major
(Assignee)

Comment 2

9 years ago
it's interesting but we have two implementation of navigation methods for access nodes (nsAccessNode and nsAccessNodeWrap).
(Assignee)

Comment 3

9 years ago
nsAccessNode naviagation methods were implemented in bug 208922. I don't see a reason why nsAccessNode has own but similar logic. So I think we should merge them.
(Assignee)

Comment 4

9 years ago
changing summary because nsAccessNode navigation methods use the cache :)
Summary: nsIAccessNode navigation methods creates nsAccessNode everytime → ISimpleDOMNode navigation methods creates nsAccessNodeWrap everytime
(Assignee)

Comment 5

9 years ago
Created attachment 342222 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #342222 - Flags: review?(aaronleventhal)
(Assignee)

Updated

9 years ago
Attachment #342222 - Flags: review?(marco.zehe)

Updated

9 years ago
Attachment #342222 - Flags: review?(marco.zehe) → review+

Comment 6

9 years ago
Comment on attachment 342222 [details] [diff] [review]
patch

r=me for the test. Thanks!

Updated

9 years ago
Attachment #342222 - Flags: review?(aaronleventhal) → review+
(Assignee)

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/c0424e568b5e
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Flags: in-testsuite+

Comment 8

9 years ago
Had to back this one out because it breaks JAWS on a wide scale. For example on http://www.heise.de/newsticker, there are only 4 headings instead of 18, and 296 instead of 346 links etc.

Question: Do we have a tool to look at the iSimpleDomNode tree?

More info: IAccessible2 is unaffected by this, that tree is still intact. Both Window-Eyes and NVDA don't suffer from this change at all.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

9 years ago
Marco, could you retest this patch since bug 472662 is fixed?
(In reply to comment #9)
> Marco, could you retest this patch since bug 472662 is fixed?

No luck. When loading the page http://www.heise.de/newsticker, the heading level 1 named "7-Tage-News", the following heading "05.05.2009", and the first link underneath that are not rendered to JAWS. This is just one example of content that's being missed with this patch.
Do we still want to get moving on this? Last patch I tried still had problems as the last comment suggests.
(Assignee)

Comment 12

6 years ago
(In reply to Marco Zehe (:MarcoZ) from comment #11)
> Do we still want to get moving on this? Last patch I tried still had
> problems as the last comment suggests.

ATs wants us to support ISimpleDOMNode, so it sounds like we should keep this bug.
(Assignee)

Comment 13

5 years ago
I wasn't contacted to make it fixed so it doesn't seem to be a real problem for ATs. We change ISimpleDOMNode implementation making it as tear off so this bug should be marked wontfix.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.