457532 - GC_ZEAL is not zealous enough when JS_THREADSAFE is enabled

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

Currently with the JS_GC_ZEAL enabled the allocation code in jsgc.cpp still does not run the GC on each allocation with JS_THREADSAFE builds. This is due to allocation from thread-local lists which defeats the purpose of having gczeal in the first place. This should be fixed to ensure uniform GC zeal semantics.

Comment 1

[Igor Bukanov]

Attachment: fix

The patch makes sure that with the defined zeal the local lists are not used. For simplicity the patch removes in RefillDoubleFreeList JS_ASSERT(!cx->doubleFreeList) since RefillDoubleFreeList does not care about the local lists stored in the JSContext.

Comment 2

[Nochum Sossonko [:Natch]]

These bugs are all part of a search I made for js bugs that are getting lost in transit:

http://tinyurl.com/jsDeadEndBugs

They all have a review+'ed, non-obsoleted patch and are not marked fixed-in-tracemonkey or checkin-needed but have not seen any activity in 300 days. Some of these got lost simply because the assignee/patch provider never requested a checkin, or just because they were forgotten about.

Comment 3

[André Bargull [:anba]]

JS_THREADSAFE doesn't exist anymore -> INVALID.