457757 - assertion when trying to restore selection to missing message

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David :Bienvenu]

I believe in this case the thread is empty.

 	mork.dll!morkEnv::NewError(const char * inString=0x02b4eab8)  Line 404 + 0x13 bytes	C++
 	mork.dll!morkArray::IndexBeyondEndError(morkEnv * ev=0x06799858)  Line 157	C++
 	mork.dll!morkArray::SafeAt(morkEnv * ev=0x06799858, int inPos=0x00000000)  Line 222 + 0x9 bytes	C++
 	mork.dll!morkTable::SafeRowAt(morkEnv * ev=0x06799858, int inPos=0x00000000)  Line 563 + 0x1a bytes	C++
 	mork.dll!morkTable::PosToOid(nsIMdbEnv * mev=0x06799884, int inRowPos=0x00000000, mdbOid * outOid=0x0012dc04)  Line 492 + 0x13 bytes	C++
 	msgdb.dll!nsMsgThread::GetChildKeyAt(int aIndex=0x00000000, unsigned int * result=0x0012dc50)  Line 453 + 0x28 bytes	C++
 	msgbase.dll!nsMsgDBView::GetKeyOfFirstMsgInThread(unsigned int key=0x00000a22)  Line 4142	C++
 	msgbase.dll!nsMsgDBView::FindKey(unsigned int key=0x00000a22, int expand=0x00000001)  Line 4170 + 0xc bytes	C++
 	msgbase.dll!nsMsgDBView::RestoreSelection(unsigned int aCurrentMsgKey=0x00000a22, nsTArray<unsigned int> & aMsgKeyArray={...})  Line 824 + 0x16 bytes	C++
 	msgbase.dll!nsMsgDBView::SelectMsgByKey(unsigned int aKey=0x00000a22)  Line 6484 + 0x10 bytes	C++

Comment 1

[David :Bienvenu]

Attachment: proposed fix

return nsMsgKey_None for invalid range, and an error. This will stop the assertion.

Comment 2

[David :Bienvenu]

you can try running with this patch, Dan.

Comment 3

[[e-mail]]

Comment on attachment 341026 [details] [diff] [review]
proposed fix

>+    *aResult = nsMsgKey_None;
>+    return NS_ERROR_ILLEGAL_VALUE;
Nit: under XPCOM rules you're not supposed to write outparams when returning failure. (I know you only do this because your caller doesn't check.)

Comment 4

[David :Bienvenu]

fix checked in - yes, the caller doesn't check...